pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rdhabalia commented on a change in pull request #2187: Removed the `Context.ack(byte[] messageId)` and expose `Record` instead
Date Tue, 17 Jul 2018 22:09:58 GMT
rdhabalia commented on a change in pull request #2187:  Removed the `Context.ack(byte[] messageId)`
and expose `Record` instead 
URL: https://github.com/apache/incubator-pulsar/pull/2187#discussion_r203197794
 
 

 ##########
 File path: pulsar-io/kinesis/pom.xml
 ##########
 @@ -38,6 +38,13 @@
       <version>${project.version}</version>
     </dependency>
 
+    <dependency>
+      <groupId>${project.groupId}</groupId>
+      <artifactId>pulsar-functions-instance</artifactId>
+      <version>${project.version}</version>
+      <scope>provided</scope>
 
 Review comment:
   why provided?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message