pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers
Date Mon, 16 Jul 2018 01:53:41 GMT
sijie commented on a change in pull request #2101: Migrate compaction and s3 offload test to
testcontainers
URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202562416
 
 

 ##########
 File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/topologies/PulsarCluster.java
 ##########
 @@ -176,15 +189,17 @@ public void start() throws Exception {
 
         // start external services
         Map<String, GenericContainer<?>> externalServices = spec.externalServices;
-        if (null != externalServices) {
-            externalServices.entrySet().forEach(service -> {
+        if (externalServices != null) {
 
 Review comment:
   I would prefer not to mix style changes with functionality changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message