pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api
Date Fri, 13 Jul 2018 17:39:00 GMT
ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client`
api with `jclouds` related api 
URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202419213
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/offload/impl/BackedInputStreamImpl.java
 ##########
 @@ -50,10 +44,10 @@
     private long bufferOffsetStart;
     private long bufferOffsetEnd;
 
-    public S3BackedInputStreamImpl(AmazonS3 s3client, String bucket, String key,
-                                   VersionCheck versionCheck,
-                                   long objectLen, int bufferSize) {
-        this.s3client = s3client;
+    public BackedInputStreamImpl(BlobStore blobStore, String bucket, String key,
 
 Review comment:
   Rename BlobStoreBackedInputStreamImpl

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message