pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers
Date Fri, 13 Jul 2018 16:37:48 GMT
ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test
to testcontainers
URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202403693
 
 

 ##########
 File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/topologies/PulsarClusterSpec.java
 ##########
 @@ -69,6 +69,15 @@
      *
      * @return the flag whether to enable/disable container log.
      */
+    @Default
 
 Review comment:
   why is this defaulting to false? without container logs any failures are impossible to
debug.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message