pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers
Date Fri, 13 Jul 2018 16:37:48 GMT
ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test
to testcontainers
URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202403937
 
 

 ##########
 File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/topologies/PulsarClusterTestBase.java
 ##########
 @@ -57,25 +57,40 @@
         };
     }
 
+    @DataProvider(name = "ServiceAndAdminUrls")
+    public static Object[][] serviceAndAdminUrls() {
+        return new Object[][] {
+            // plain text
+            {
+                pulsarCluster.getPlainTextServiceUrl(),
+                pulsarCluster.getHttpServiceUrl()
+            }
+        };
+    }
+
     protected static PulsarCluster pulsarCluster;
 
     @BeforeClass
     public void setupCluster() throws Exception {
-        this.setupCluster("");
+        setupClusterNoWorker();
         pulsarCluster.startFunctionWorkersWithProcessContainerFactory(1);
     }
 
-    public void setupCluster(String namePrefix) throws Exception {
+    protected void setupClusterNoWorker() throws Exception {
 
 Review comment:
   Does any of this work stuff need to be in this PR? It looks unrelated. If so, move it to
another patch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message