pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] aahmed-se commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers
Date Thu, 12 Jul 2018 06:09:08 GMT
aahmed-se commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers
URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r201918716
 
 

 ##########
 File path: tests/integration/s3-offload/src/test/java/org/apache/pulsar/tests/integration/TestS3Offload.java
 ##########
 @@ -179,28 +180,20 @@ public void testPublishOffloadAndConsumeViaCLI() throws Exception {
         }
     }
 
-    @Test
-    public void testPublishOffloadAndConsumeViaThreshold() throws Exception {
+    @Test(dataProvider =  "ServiceAndAdminUrls")
+    public void testPublishOffloadAndConsumeViaThreshold(String serviceUrl, String adminUrl)
throws Exception {
 
 Review comment:
   https://github.com/apache/incubator-pulsar/pull/2101/files/77f840237aa80fef55477c16f038ef5ef6ec608a#diff-79f7bfa7dd1879a88347464ef101a81dR138

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message