pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers
Date Tue, 10 Jul 2018 18:58:56 GMT
sijie commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers
URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r201448797
 
 

 ##########
 File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/containers/BrokerContainer.java
 ##########
 @@ -29,4 +31,29 @@ public BrokerContainer(String clusterName, String hostName) {
         super(
             clusterName, hostName, hostName, "bin/run-broker.sh", BROKER_PORT, INVALID_PORT);
     }
+
+    public void stopBroker() {
+        try {
+            this.execCmd("supervisorctl", "stop", "broker");
+        } catch (Exception ex){
+
+        }
+    }
+
+    public void startBroker() {
+        try {
+            this.execCmd("supervisorctl", "start", "broker");
+        } catch (Exception ex){
+        }
+    }
+
+    public void updateConf(String configFile, String key, String value) {
 
 Review comment:
   any configuration updates should just be done by specifying the configuration settings
as docker environment variables. 
   
   for example: https://github.com/apache/incubator-pulsar/blob/master/tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/topologies/PulsarCluster.java#L159

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message