pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ivankelly commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers
Date Mon, 09 Jul 2018 09:38:05 GMT
ivankelly commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers
URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r200939801
 
 

 ##########
 File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/topologies/PulsarCluster.java
 ##########
 @@ -112,6 +108,12 @@ private PulsarCluster(PulsarClusterSpec spec) {
             .withEnv("zookeeperServers", ZKContainer.NAME)
             .withEnv("configurationStoreServers", CSContainer.NAME + ":" + CS_PORT)
             .withEnv("clusterName", clusterName);
+
+        this.s3Container = new S3Container(clusterName, S3Container.NAME)
 
 Review comment:
   It'd be better to create a subclass of PulsarCluster, PulsarClusterWithS3, and only start
S3 in that case. As it is now, S3 is being started for all cases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message