ivankelly opened a new pull request #1889: Encrypted or compressed payloads can be compacted
out if empty
URL: https://github.com/apache/incubator-pulsar/pull/1889
Compressed payloads don't have zero size, even if the uncompressed
payload is empty, so if a payload was empty, it wouldn't delete that key
from the compaction result.
Similarly for encrypted messages, zero size unencrypted doesn't map to
zero size encrypted.
This patch adds special handling to use getUncompressedSize() to find
the size of the payload, rather than looking at the readableBytes of
the payload. UncompressedSize is now set for all messages.
We still fall back to using readableBytes for the case where we have
an old client that isn't updating UncompressedSize.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
|