pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jerryp...@apache.org
Subject [incubator-pulsar] branch master updated: [functions] Dont shade log4j2 in java runtime instance (#1881)
Date Fri, 01 Jun 2018 00:17:30 GMT
This is an automated email from the ASF dual-hosted git repository.

jerrypeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new fc3c1b3  [functions] Dont shade log4j2 in java runtime instance (#1881)
fc3c1b3 is described below

commit fc3c1b383c80202f5c69cfac704b52655b211d50
Author: Sijie Guo <guosijie@gmail.com>
AuthorDate: Thu May 31 17:17:23 2018 -0700

    [functions] Dont shade log4j2 in java runtime instance (#1881)
    
    *Motivation*
    
     #1849 shade the dependencies in java instance uber jar. However it
     shades the log4j2, which causes functions running in process mode
     can't output any logging messages.
    
    *Solution*
    
    Don't shade log4j2 in java runtime instance
---
 pulsar-functions/runtime-all/pom.xml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/pulsar-functions/runtime-all/pom.xml b/pulsar-functions/runtime-all/pom.xml
index 64e58e3..6c16916 100644
--- a/pulsar-functions/runtime-all/pom.xml
+++ b/pulsar-functions/runtime-all/pom.xml
@@ -207,10 +207,12 @@
                   <pattern>jersey</pattern>
                   <shadedPattern>org.apache.pulsar.functions.runtime.shaded.jersey</shadedPattern>
                 </relocation>
+                <!-- DONT ever shade log4j, otherwise logging won't work anymore in running
functions in process mode
                 <relocation>
                   <pattern>org.apache.logging</pattern>
                   <shadedPattern>org.apache.pulsar.functions.runtime.shaded.org.apache.logging</shadedPattern>
                 </relocation>
+                -->
                 <relocation>
                   <pattern>javassist</pattern>
                   <shadedPattern>org.apache.pulsar.functions.runtime.shaded.javassist</shadedPattern>

-- 
To stop receiving notification emails like this one, please contact
jerrypeng@apache.org.

Mime
View raw message