Mailing-List: contact commits-help@pulsar.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@pulsar.incubator.apache.org
From: GitBox <git@apache.org>
To: commits@pulsar.apache.org
Subject: [GitHub] merlimat commented on a change in pull request #883: Do not used Pooled allocator for stats buffers
Message-ID: <150974447454.18640.2849840764684836183.gitbox@gitbox.apache.org>
archived-at: Fri, 03 Nov 2017 21:27:56 -0000

merlimat commented on a change in pull request #883: Do not used Pooled allocator for stats buffers
URL: https://github.com/apache/incubator-pulsar/pull/883#discussion_r148897112
 
 
 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarStats.java
 ##########
 @@ -60,8 +60,8 @@
     private final ReentrantReadWriteLock bufferLock = new ReentrantReadWriteLock();
 
     public PulsarStats(PulsarService pulsar) {
-        this.topicStatsBuf = PooledByteBufAllocator.DEFAULT.heapBuffer(16 * 1024);
-        this.tempTopicStatsBuf = PooledByteBufAllocator.DEFAULT.heapBuffer(16 * 1024);
+        this.topicStatsBuf = Unpooled.buffer(16 * 1024);
 
 Review comment:
   I think we need the byte[] to write the result into an OutputStrean

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services