Return-Path: <commits-return-1525-archive-asf-public=cust-asf.ponee.io@pulsar.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 2C8E2200D34
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri,  3 Nov 2017 18:40:01 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 2B0D9160BFB; Fri,  3 Nov 2017 17:40:01 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 745F4160BDE
	for <archive-asf-public@cust-asf.ponee.io>; Fri,  3 Nov 2017 18:40:00 +0100 (CET)
Received: (qmail 80928 invoked by uid 500); 3 Nov 2017 17:39:59 -0000
Mailing-List: contact commits-help@pulsar.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@pulsar.incubator.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@pulsar.incubator.apache.org>
List-Post: <mailto:commits@pulsar.incubator.apache.org>
List-Id: <commits.pulsar.incubator.apache.org>
Reply-To: dev@pulsar.incubator.apache.org
Delivered-To: mailing list commits@pulsar.incubator.apache.org
Received: (qmail 80919 invoked by uid 99); 3 Nov 2017 17:39:59 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Nov 2017 17:39:59 +0000
From: GitBox <git@apache.org>
To: commits@pulsar.apache.org
Subject: [GitHub] jai1 closed pull request #880: CPP Client - Athens Client header visibile and remove C++11 features
Message-ID: <150973079914.23315.8513293685169705926.gitbox@gitbox.apache.org>
archived-at: Fri, 03 Nov 2017 17:40:01 -0000

jai1 closed pull request #880: CPP Client - Athens Client header visibile and remove C++11 features
URL: https://github.com/apache/incubator-pulsar/pull/880
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pulsar-client-cpp/lib/auth/AuthAthenz.cc b/pulsar-client-cpp/lib/auth/AuthAthenz.cc
index 4c5558e76..dd05a6597 100644
--- a/pulsar-client-cpp/lib/auth/AuthAthenz.cc
+++ b/pulsar-client-cpp/lib/auth/AuthAthenz.cc
@@ -77,8 +77,9 @@ namespace pulsar {
             Json::Value root;
             Json::Reader reader;
             if (reader.parse(authParamsString, root, false)) {
-                for (auto key: root.getMemberNames()) {
-                    params[key] = root[key].asString();
+                Json::Value::Members members = root.getMemberNames();
+                for (Json::Value::Members::iterator iter = members.begin(); iter != members.end(); iter++) {
+                    params[*iter] = root[*iter].asString();
                 }
             } else {
                 LOG_ERROR("Invalid String Error: " << reader.getFormatedErrorMessages());
diff --git a/pulsar-client-cpp/lib/auth/athenz/ZTSClient.cc b/pulsar-client-cpp/lib/auth/athenz/ZTSClient.cc
index caa700d4b..da32baab7 100644
--- a/pulsar-client-cpp/lib/auth/athenz/ZTSClient.cc
+++ b/pulsar-client-cpp/lib/auth/athenz/ZTSClient.cc
@@ -143,7 +143,7 @@ namespace pulsar {
         size_t length = strlen(input);
         char *result = (char*)malloc(length);
 
-        bio = BIO_new_mem_buf(input, -1);
+        bio = BIO_new_mem_buf((void *)input, -1);
         b64 = BIO_new(BIO_f_base64());
         bio = BIO_push(b64, bio);
 
diff --git a/pulsar-client-cpp/lib/auth/athenz/ZTSClient.h b/pulsar-client-cpp/lib/auth/athenz/ZTSClient.h
index de1b8ed7a..c27dbb580 100644
--- a/pulsar-client-cpp/lib/auth/athenz/ZTSClient.h
+++ b/pulsar-client-cpp/lib/auth/athenz/ZTSClient.h
@@ -20,6 +20,7 @@
 #include <map>
 #include <lib/LogUtils.h>
 #include <boost/thread.hpp>
+#pragma GCC visibility push(default)
 
 namespace pulsar {
 
@@ -61,3 +62,4 @@ namespace pulsar {
         friend class ZTSClientWrapper;
     };
 }
+#pragma GCC visibility pop


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services