pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rdhabalia commented on a change in pull request #923: Upgrade to bk-4.3.1.83-yahoo to expose journalSyncData option
Date Thu, 01 Jan 1970 00:00:00 GMT
rdhabalia commented on a change in pull request #923: Upgrade to bk-4.3.1.83-yahoo to expose
journalSyncData option
URL: https://github.com/apache/incubator-pulsar/pull/923#discussion_r153695650
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -106,15 +106,15 @@ flexible messaging model and an intuitive client API.</description>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
 
-    <bookkeeper.version>4.3.1.82-yahoo</bookkeeper.version>
+    <bookkeeper.version>4.3.1.83-yahoo</bookkeeper.version>
 
 Review comment:
   I didn't realize that we incremented bk version from `4.3.1.72-yahoo` to `4.3.1.82-yahoo`
 in #689. In past it was always useful to know BK-changes in the PR when we have incremented
bk-version to confirm changes in case of any issue (as it's tricky in yahooBK to know changes
for a specific version).
   is it fine to mention changes or just commit-range from [f87e0eda574](https://github.com/yahoo/bookkeeper/commit/f87e0eda574fb5f9d22dd7d92422eb221199a92c)
to [165971209](https://github.com/yahoo/bookkeeper/commit/165971209f933e0bcefaac997db8e75c8776f942)
in PR description.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message