pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #903: PIP-8: Introduce peer cluster for global namespace redirection
Date Thu, 01 Jan 1970 00:00:00 GMT
merlimat commented on a change in pull request #903: PIP-8: Introduce peer cluster for global
namespace redirection
URL: https://github.com/apache/incubator-pulsar/pull/903#discussion_r151775910
 
 

 ##########
 File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/ClusterData.java
 ##########
 @@ -18,13 +18,19 @@
  */
 package org.apache.pulsar.common.policies.data;
 
+import java.util.List;
+
 import com.google.common.base.Objects;
+import static com.google.common.base.Preconditions.checkNotNull;
 
 public class ClusterData {
     private String serviceUrl;
     private String serviceUrlTls;
     private String brokerServiceUrl;
     private String brokerServiceUrlTls;
+    // For given Cluster1(us-west1, us-east1) and Cluster2(us-west2, us-east2)
+    // Peer: [us-west1 -> us-west2] and [us-east1 -> us-east2]
+    private List<String> peerClusterNames;
 
 Review comment:
   Should we just use `Set<String>` since it's supposed to contain unique values?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message