pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #883: Do not used Pooled allocator for stats buffers
Date Thu, 01 Jan 1970 00:00:00 GMT
merlimat commented on a change in pull request #883: Do not used Pooled allocator for stats
buffers
URL: https://github.com/apache/incubator-pulsar/pull/883#discussion_r148897112
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarStats.java
 ##########
 @@ -60,8 +60,8 @@
     private final ReentrantReadWriteLock bufferLock = new ReentrantReadWriteLock();
 
     public PulsarStats(PulsarService pulsar) {
-        this.topicStatsBuf = PooledByteBufAllocator.DEFAULT.heapBuffer(16 * 1024);
-        this.tempTopicStatsBuf = PooledByteBufAllocator.DEFAULT.heapBuffer(16 * 1024);
+        this.topicStatsBuf = Unpooled.buffer(16 * 1024);
 
 Review comment:
   I think we need the byte[] to write the result into an OutputStrean

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message