pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #879: Use 127.0.0.1 in standalone and clean the cookie in case of conflicts
Date Thu, 01 Jan 1970 00:00:00 GMT
merlimat commented on a change in pull request #879: Use 127.0.0.1 in standalone and clean
the cookie in case of conflicts
URL: https://github.com/apache/incubator-pulsar/pull/879#discussion_r148689639
 
 

 ##########
 File path: pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/zookeeper/LocalBookkeeperEnsemble.java
 ##########
 @@ -174,7 +175,22 @@ private void runBookies(ServerConfiguration baseConf) throws Exception
{
             bsConfs[i].setAllowLoopback(true);
             bsConfs[i].setGcWaitTime(60000);
 
-            bs[i] = new BookieServer(bsConfs[i], NullStatsLogger.INSTANCE);
+            try {
+                bs[i] = new BookieServer(bsConfs[i], NullStatsLogger.INSTANCE);
+            } catch (InvalidCookieException e) {
+                // InvalidCookieException can happen if the machine IP has changed
 
 Review comment:
   The `start()` is just used within unit tests, so it's safe to clear it as well. It's not
used when launching the bookie with `bin/pulsar bookie`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message