portals-pluto-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From asfgr...@apache.org
Subject portals-pluto git commit: Improve tests
Date Thu, 15 Dec 2016 18:34:45 GMT
Repository: portals-pluto
Updated Branches:
  refs/heads/master a95786af9 -> 1733ade4f


Improve tests

- Use configured port and host in test.server.login.url property

- Fix V2EnvironmentTests_PortletContext_ApiRender_getRealPath3 on Unix systems

    Only forward slash ("/") and null are invalid characters in file names on
    Unix systems.


Project: http://git-wip-us.apache.org/repos/asf/portals-pluto/repo
Commit: http://git-wip-us.apache.org/repos/asf/portals-pluto/commit/1733ade4
Tree: http://git-wip-us.apache.org/repos/asf/portals-pluto/tree/1733ade4
Diff: http://git-wip-us.apache.org/repos/asf/portals-pluto/diff/1733ade4

Branch: refs/heads/master
Commit: 1733ade4fa99f6c53c2f159c46577f0cbd00cc79
Parents: a95786a
Author: Kyle Stiemann <stiemannkj1@gmail.com>
Authored: Wed Dec 14 14:37:02 2016 -0500
Committer: Neil Griffin <neil.griffin.scm@gmail.com>
Committed: Thu Dec 15 13:31:35 2016 -0500

----------------------------------------------------------------------
 .../portlets/EnvironmentTests_PortletContext_ApiRender.java    | 4 ++--
 portlet-tck_3.0/pom.xml                                        | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/portals-pluto/blob/1733ade4/portlet-tck_3.0/V2EnvironmentTests/src/main/java/javax/portlet/tck/portlets/EnvironmentTests_PortletContext_ApiRender.java
----------------------------------------------------------------------
diff --git a/portlet-tck_3.0/V2EnvironmentTests/src/main/java/javax/portlet/tck/portlets/EnvironmentTests_PortletContext_ApiRender.java
b/portlet-tck_3.0/V2EnvironmentTests/src/main/java/javax/portlet/tck/portlets/EnvironmentTests_PortletContext_ApiRender.java
index 47d0709..05a953d 100644
--- a/portlet-tck_3.0/V2EnvironmentTests/src/main/java/javax/portlet/tck/portlets/EnvironmentTests_PortletContext_ApiRender.java
+++ b/portlet-tck_3.0/V2EnvironmentTests/src/main/java/javax/portlet/tck/portlets/EnvironmentTests_PortletContext_ApiRender.java
@@ -383,11 +383,11 @@ public class EnvironmentTests_PortletContext_ApiRender implements Portlet
{
         tcd.getTestResultFailed(V2ENVIRONMENTTESTS_PORTLETCONTEXT_APIRENDER_GETREALPATH3);
     try {
       String realPath =
-          pc.getRealPath("&^*#V2EnvironmentTests_PortletContext_ApiRender_getMimeType4.invalid");
+          pc.getRealPath("&^*#\\/V2EnvironmentTests_PortletContext_ApiRender_getMimeType4.invalid");
       if (realPath == null) {
         tr18.setTcSuccess(true);
       } else {
-        tr18.appendTcDetail("Failed because real path if not null but " + realPath);
+        tr18.appendTcDetail("Failed because real path is not null but " + realPath);
       }
     } catch (Exception e) {
       tr18.appendTcDetail(e.toString());

http://git-wip-us.apache.org/repos/asf/portals-pluto/blob/1733ade4/portlet-tck_3.0/pom.xml
----------------------------------------------------------------------
diff --git a/portlet-tck_3.0/pom.xml b/portlet-tck_3.0/pom.xml
index 368050f..7a0daef 100644
--- a/portlet-tck_3.0/pom.xml
+++ b/portlet-tck_3.0/pom.xml
@@ -87,14 +87,14 @@
          modules -->
       <test.url.strategy>followLinks</test.url.strategy>
 
-      <!-- Configuration of URL to login page -->
-      <test.server.login.url>http://localhost:8080/pluto/portal/About Apache Pluto</test.server.login.url>
-
       <!-- Configuration of portlet container under test for generated URLs -->
       <!-- (only needed if test.url.strategy=generateURLs) -->
       <test.server.host>localhost</test.server.host>
       <test.server.port>8080</test.server.port>
 
+      <!-- Configuration of URL to login page -->
+      <test.server.login.url>http://${test.server.host}:${test.server.port}/pluto/portal/About
Apache Pluto</test.server.login.url>
+
       <!-- HTML field IDs and values for username & password to enable automatic 
login -->
 	  <!-- User specified must be in 'tckuser' role. Please configure 'tckuser' role for
the specified user in tomcat-users.xml -->
       <test.server.username.id>j_username</test.server.username.id>


Mime
View raw message