Return-Path: Delivered-To: apmail-portals-pluto-scm-archive@www.apache.org Received: (qmail 67257 invoked from network); 5 Jan 2009 16:17:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 Jan 2009 16:17:56 -0000 Received: (qmail 90466 invoked by uid 500); 5 Jan 2009 16:17:56 -0000 Delivered-To: apmail-portals-pluto-scm-archive@portals.apache.org Received: (qmail 90440 invoked by uid 500); 5 Jan 2009 16:17:56 -0000 Mailing-List: contact pluto-scm-help@portals.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list pluto-scm@portals.apache.org Received: (qmail 90431 invoked by uid 99); 5 Jan 2009 16:17:56 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Jan 2009 08:17:56 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Jan 2009 16:17:54 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id EBDD62388988; Mon, 5 Jan 2009 08:17:33 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r731609 - /portals/pluto/trunk/pluto-container/src/main/java/org/apache/pluto/internal/impl/PortletRequestImpl.java Date: Mon, 05 Jan 2009 16:17:33 -0000 To: pluto-scm@portals.apache.org From: vkumar@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090105161733.EBDD62388988@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: vkumar Date: Mon Jan 5 08:17:33 2009 New Revision: 731609 URL: http://svn.apache.org/viewvc?rev=731609&view=rev Log: Fixing isPortletModeAllowedByPortlet method, Only VIEW mode is mandatory, as per spec. Modified: portals/pluto/trunk/pluto-container/src/main/java/org/apache/pluto/internal/impl/PortletRequestImpl.java Modified: portals/pluto/trunk/pluto-container/src/main/java/org/apache/pluto/internal/impl/PortletRequestImpl.java URL: http://svn.apache.org/viewvc/portals/pluto/trunk/pluto-container/src/main/java/org/apache/pluto/internal/impl/PortletRequestImpl.java?rev=731609&r1=731608&r2=731609&view=diff ============================================================================== --- portals/pluto/trunk/pluto-container/src/main/java/org/apache/pluto/internal/impl/PortletRequestImpl.java (original) +++ portals/pluto/trunk/pluto-container/src/main/java/org/apache/pluto/internal/impl/PortletRequestImpl.java Mon Jan 5 08:17:33 2009 @@ -788,7 +788,7 @@ private boolean isPortletModeAllowedByPortlet(PortletMode mode) { - if (isPortletModeMandatory(mode)) + if(PortletMode.VIEW.equals(mode)) { return true; } @@ -826,12 +826,6 @@ return false; } - private boolean isPortletModeMandatory(PortletMode mode) - { - return PortletMode.VIEW.equals(mode) || PortletMode.EDIT.equals(mode) || PortletMode.HELP.equals(mode); - } - - // InternalRenderRequest Impl ---------------------------------------------- public Cookie[] getCookieProperties()