portals-pluto-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dettb...@apache.org
Subject svn commit: r612046 - in /portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite: ./ test/
Date Tue, 15 Jan 2008 09:07:58 GMT
Author: dettborn
Date: Tue Jan 15 01:07:57 2008
New Revision: 612046

URL: http://svn.apache.org/viewvc?rev=612046&view=rev
Log:
-change the api
-add not implemented functions
-cleanup the code and delete old fixme's
	-delete old todo(I save the patch so I update the jira issues)
	

Modified:
    portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/TestConfig.java
    portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/ContextInitParameterTest.java
    portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/PreferenceCommonTest.java
    portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/PreferenceInActionTest.java
    portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/RenderResponseNoContentTypeTest.java

Modified: portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/TestConfig.java
URL: http://svn.apache.org/viewvc/portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/TestConfig.java?rev=612046&r1=612045&r2=612046&view=diff
==============================================================================
--- portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/TestConfig.java
(original)
+++ portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/TestConfig.java
Tue Jan 15 01:07:57 2008
@@ -55,16 +55,7 @@
      */
     private List<Parameter> actionParameters = new ArrayList<Parameter>();
 
-    /**
-     * The render parameters list holding TestConfig.Parameter objects.
-     * We are not using Map to hold render parameters because parameters with
-     * the same name are allowed.
-     *
-     * FIXME: when is this field used?
-     */
-//    private List renderParameters = new ArrayList();
-
-
+    
     // Constructor -------------------------------------------------------------
 
     /**
@@ -115,24 +106,6 @@
     public List<Parameter> getActionParameters() {
     	return actionParameters;
     }
-
-    /**
-     * FIXME: why is this method required?
-     */
-    /*
-    public void addRenderParameter(String name, String value) {
-    	renderParameters.add(new Parameter(name, value));
-    }
-    */
-
-    /**
-     * FIXME: when is this method used?
-     */
-    /*
-    public List getRenderParameters() {
-    	return renderParameters;
-    }
-    */
 
     public String toString() {
     	StringBuffer buffer = new StringBuffer();

Modified: portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/ContextInitParameterTest.java
URL: http://svn.apache.org/viewvc/portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/ContextInitParameterTest.java?rev=612046&r1=612045&r2=612046&view=diff
==============================================================================
--- portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/ContextInitParameterTest.java
(original)
+++ portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/ContextInitParameterTest.java
Tue Jan 15 01:07:57 2008
@@ -77,7 +77,7 @@
     }
 
     /**
-     * FIXME: should this test reside in this class?  -- ZHENG Zhong
+     * 
      */
     protected TestResult checkGetContextFromSession(PortletSession session) {
         TestResult result = new TestResult();

Modified: portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/PreferenceCommonTest.java
URL: http://svn.apache.org/viewvc/portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/PreferenceCommonTest.java?rev=612046&r1=612045&r2=612046&view=diff
==============================================================================
--- portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/PreferenceCommonTest.java
(original)
+++ portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/PreferenceCommonTest.java
Tue Jan 15 01:07:57 2008
@@ -395,9 +395,7 @@
         return result;
     }
 
-    /**
-     * FIXME:
-     */
+    
     protected TestResult checkGetPreferenceMap(PortletRequest request) {
         TestResult result = checkGetPreferenceNames(request);
         result.setDescription("Ensure returned map is valid.");

Modified: portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/PreferenceInActionTest.java
URL: http://svn.apache.org/viewvc/portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/PreferenceInActionTest.java?rev=612046&r1=612045&r2=612046&view=diff
==============================================================================
--- portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/PreferenceInActionTest.java
(original)
+++ portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/PreferenceInActionTest.java
Tue Jan 15 01:07:57 2008
@@ -73,7 +73,6 @@
         } catch (ValidatorException ex) {
         	// We are expecting this exception!
             exceptionThrown = true;
-            // FIXME: what is going on below?
             try {
             	//get rid of spaces because it causes problems with reset() call.
                 preferences.setValue("TEST", "OK");

Modified: portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/RenderResponseNoContentTypeTest.java
URL: http://svn.apache.org/viewvc/portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/RenderResponseNoContentTypeTest.java?rev=612046&r1=612045&r2=612046&view=diff
==============================================================================
--- portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/RenderResponseNoContentTypeTest.java
(original)
+++ portals/pluto/trunk/pluto-testsuite/src/main/java/org/apache/pluto/testsuite/test/RenderResponseNoContentTypeTest.java
Tue Jan 15 01:07:57 2008
@@ -26,10 +26,7 @@
 import org.apache.pluto.testsuite.TestResult;
 import org.apache.pluto.testsuite.TestUtils;
 
-/**
- * FIXME: separate the two check methods to two classes.
- *
- */
+
 public class RenderResponseNoContentTypeTest
 extends AbstractReflectivePortletTest {
 



Mime
View raw message