I recently discovered that there's yet another spec I didn't know about, jsr 188 ccpp. Looking at the sun download link I get to the license agreement: https://cds.sun.com/is-bin/INTERSHOP.enfinity/WFS/CDS-CDS_Developer-Site/en_US/-/USD/ViewLicense-Start which doesn't look to me very apache-friendly. It also looks to me from the dev list emails back on aug 28-29 2007 that a pluto committer requested the api jar be uploaded to the maven central repo. I'm wondering what the legal basis for doing this was since it is not obvious to me that the license linked above would permit this. Has anyone established whether or not it is legally acceptable to include the api jar in a download from apache? thanks david jencks
[ https://issues.apache.org/jira/browse/PLUTO-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785221#action_12785221
]
David Jencks commented on PLUTO-585:
------------------------------------
rev 886700 builds bundles instead of plain jars and makes a few osgi package imports optional.
I can get all the jars to load in geronimo but don't know if anything works yet.
> Make pluto more osgi friendly
> -----------------------------
>
> Key: PLUTO-585
> URL: https://issues.apache.org/jira/browse/PLUTO-585
> Project: Pluto
> Issue Type: Bug
> Components: general
> Affects Versions: 2.0.1
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.0.1
>
>
> Geronimo needs pluto to come with more osgi support. We don't know yet exactly what
this will entail. Some possible bits:
> 1. make the jars into osgi bundles. This should be completely non-controversial and
easy.
> 2. use the osgi blueprint service instead of spring. This could be an optional other
way of assembling the portal (most likely) or a replacement (I doubt this would be acceptable
to everyone at this point).
> 3. Investigate deploying the wars as rfc 66 web app bundles. I'm not sure whether or
not this would be useful for geronimo.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/PLUTO-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785219#action_12785219
]
David Jencks commented on PLUTO-387:
------------------------------------
Somehow the removepage method got lost in the RenderConfigAdminService on the way to 2.0.
I added it back in rev 886695.
> Provide add/remove page functionality to Pluto Portal Driver
> ------------------------------------------------------------
>
> Key: PLUTO-387
> URL: https://issues.apache.org/jira/browse/PLUTO-387
> Project: Pluto
> Issue Type: Improvement
> Components: portal driver
> Affects Versions: 1.1.0, 1.1.1, 1.1.2, 1.1.3
> Reporter: Ajay Panagariya
> Assignee: Craig Doremus
> Fix For: 1.1.4, 1.2.0
>
> Attachments: pluto-387.patch, pluto-387.patch
>
>
> The Page Admin Portlet needs the ability to add and remove pages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Make pluto more osgi friendly
-----------------------------
Key: PLUTO-585
URL: https://issues.apache.org/jira/browse/PLUTO-585
Project: Pluto
Issue Type: Bug
Components: general
Affects Versions: 2.0.1
Reporter: David Jencks
Assignee: David Jencks
Fix For: 2.0.1
Geronimo needs pluto to come with more osgi support. We don't know yet exactly what this
will entail. Some possible bits:
1. make the jars into osgi bundles. This should be completely non-controversial and easy.
2. use the osgi blueprint service instead of spring. This could be an optional other way
of assembling the portal (most likely) or a replacement (I doubt this would be acceptable
to everyone at this point).
3. Investigate deploying the wars as rfc 66 web app bundles. I'm not sure whether or not
this would be useful for geronimo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Unalbe to add a portlet application through Pulto Admin
-------------------------------------------------------
Key: PLUTO-584
URL: https://issues.apache.org/jira/browse/PLUTO-584
Project: Pluto
Issue Type: Bug
Components: portlets-admin
Affects Versions: 2.0.0
Environment: Windows XP / Apache tomcat 6
Reporter: Abani Ranjan Behera
Unalbe to add a portlet application through Pulto Admin. When ever the portlet is deployed
through manager application then the portlet option is not coming in the available portlets
option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
This is the error message:
Description Resource Path Location Type
Web application descriptor must be a valid web.xml Copy of
Spring-Portlet-JSR286-2.0final prueba final line 1 Maven Problem
<?xml version="1.0" encoding="UTF-8"?>
<web-app xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="
http://java.sun.com/xml/ns/javaee" xmlns:web="
http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd" xsi:schemaLocation="
http://java.sun.com/xml/ns/javaee
http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd" id="WebApp_ID"
version="2.5">
<display-name>PortletPrueba</display-name>
<servlet>
<servlet-name>TestPortlet</servlet-name>
<servlet-class>org.apache.pluto.core.PortletServlet</servlet-class>
<init-param>
<param-name>portlet-name</param-name>
<param-value>TestPortlet</param-value>
</init-param>
<load-on-startup>1</load-on-startup>
</servlet>
<servlet-mapping>
<servlet-name>TestPortlet</servlet-name>
<url-pattern>/PlutoInvoker/TestPortlet</url-pattern>
</servlet-mapping>
</web-app>
dog somebody send me to web.xml been worth of example?
PortalURLParserImpl: unnecessary "?"
------------------------------------
Key: PLUTO-583
URL: https://issues.apache.org/jira/browse/PLUTO-583
Project: Pluto
Issue Type: Bug
Components: portal driver
Affects Versions: 2.0.0
Reporter: Jürgen Gahl
Priority: Trivial
When creating an URL with "public String toString(PortalURL portalURL)" an unnecessary "?"
is added if the query is empty (org.apache.pluto.driver.url.impl.PortalURLParserImpl).
This is the part of the source code where the URL is finally composed:
---
// Construct the string representing the portal URL.
// Fix for PLUTO-247 - check if query string contains parameters
if ( query.length() > 1 ) {
return buffer.append(query).toString();
}
// Construct the string representing the portal URL.
return buffer.append(query).toString();
---
There was already a fix for this issue (PLUTO-247). May be this reappeared after some refactoring.
The statement in the if-block and the one behind the if-block is the same.
The unnecessary "?" caused problems when using the URL as action in a form within a HTTPUnit-Test
because the testframework does not look at the final character of the URL and adds an additional
"?".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
in doView()
response.setContentType("text/html");
PrintWriter writer = response.getWriter();
ResourceURL resURL = response.createResourceURL();
String p = "<object data=\"" + resURL.toString() + "\"" +
"type=\"application/pdf\" width=\"100%\" height=\"100%\"";
writer.print(p);
serveResource() is called then.
This works for IE and firefox but....
in IE without problems, in firefox I get a Stacktrace although I get the
document in the browser, but sometimes firefox also crashes
Does someone perhaps have a clue?
Thank you
Hubert
17:55:47,953 ERROR [[WorkflowPortlet]] Servlet.service() for servlet
WorkflowPortlet threw exception
java.net.SocketException: Connection reset by peer: socket write error
at java.net.SocketOutputStream.socketWrite0(Native Method)
at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:92)
at java.net.SocketOutputStream.write(SocketOutputStream.java:136)
--
View this message in context: http://www.nabble.com/serveResource%28%29-question-tp25962607p26029560.html
Sent from the Pluto - Dev mailing list archive at Nabble.com.
...well, it looks like it was my fault. The thread that locked the whole thing was "com.sun.jndi.ldap.Connection". And it locked, because I left a DirContext open in my application. Closing this solved the problem. hub -- View this message in context: http://www.nabble.com/Portlet-locked-with-processEvent%28%29---tp25964293p26029319.html Sent from the Pluto - Dev mailing list archive at Nabble.com.
forwarding to jsp in action phase causes error if <portlet:defineObjects/> is used in
jsp
------------------------------------------------------------------------------------------
Key: PLUTO-582
URL: https://issues.apache.org/jira/browse/PLUTO-582
Project: Pluto
Issue Type: Bug
Affects Versions: 2.0.0
Environment: windows, JBOSS 4.2.2 GA
Reporter: Hubert Felber
in the action phase I do a
getPortletContext().getRequestDispatcher("test.jsp").forward(request,response);
in test.jsp I defined
<%@ taglib uri="http://java.sun.com/portlet_2_0" prefix="portlet" %>
<portlet:defineObjects/>
The compiled jsp then contains
renderRequest = (javax.portlet.RenderRequest) _jspx_page_context.findAttribute("renderRequest");
which causes a
javax.servlet.ServletException: javax.portlet.PortletException: java.lang.ClassCastException:
org.apache.pluto.container.impl.ActionRequestImpl cannot be cast to javax.portlet.RenderRequest
org.apache.pluto.driver.PortalDriverServlet.doGet(PortalDriverServlet.java:141)
javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Hi, Please excuse me for writing in the Dev forum, but I don't notice any activity in the user forum. I think I am locking a portlet, maybe I do stuff which I should not. Could anyone please help me? I have a portlet B , loaded on startup but not visible (not displayed). Portlet A sends an event to portlet B. Portlet B receives it in processEvent() , does some stuff(creates a workflow with opensymphony/osworkflow) and would like to be rendered then ---but nothing happens. I do not notice that any portlet is rendered at all. Instead I see (visuall feedback from browser) that a request is pending, which times out after a while. Creating a new request by pressing "home" interrupts the pending request and all works fine again. But I think the request is still pending somewhere. If I don't do anything in processEvent(), the portlet get's rendered (doView()). Sometimes (rarely) it works, although I do my stuff in processEvent() (create the workflow). Sometimes my breakpoints in doView() are triggered, if I stop my application (Ctrl C), which brought me to the idea that I am locking something. While stopping the application I then see following output on the console [TomcatDeployer] undeploy, ctxPath=/pluto, warUrl=.../deploy/pluto.war/ [StandardWrapper] Waiting for 1 instance(s) to be deallocated [StandardWrapper] Waiting for 1 instance(s) to be deallocated [StandardWrapper] Waiting for 1 instance(s) to be deallocated [[/pluto]] Closing Spring root WebApplicationContext The more requests I generated, the more "Waiting ..." I see. I am running on JBoss 4.2.2 GA Are there some restrictions on what is allowed in processEvent()? Could somebody please help me to isolate the problem? Thank you for helping Regards Hubert -- View this message in context: http://www.nabble.com/Portlet-locked-with-processEvent%28%29---tp25964293p25964293.html Sent from the Pluto - Dev mailing list archive at Nabble.com.
Hi, 1. Problem: In doView() I want to display a PDF form. I call response.createResourceURL() and expect that my serveResource() function will be called, but this does not happen -- i get a blank page (there is no other output). The created resource URL is OK, if I copy/paste it to the browser, my serveResource() is called and the PDF is displayed. Question: How do I achieve to display a PDF as response to a RenderRequest ? Thank you Hubert -- View this message in context: http://www.nabble.com/serveResource%28%29-question-tp25962607p25962607.html Sent from the Pluto - Dev mailing list archive at Nabble.com.
org.apache.pluto.driver.url.impl.PortalURLParserImpl not properly decoding public/private render
parameters
-----------------------------------------------------------------------------------------------------------
Key: PLUTO-581
URL: https://issues.apache.org/jira/browse/PLUTO-581
Project: Pluto
Issue Type: Bug
Affects Versions: 2.0.0
Reporter: Michael Freedman
PortalURLParserImpl doubly encodes public/private render parameters into the path portion
of the ResourceURL but on return its parser only decodes once.
See encodeMultiValues() to see the double encoding.
Look at decodePublicParameter() to see the single decode. Instead this method should use
the same decoding strategy as decodeParameter(). namely it needs the following code added
after the call to split up the values into an array of values:
for (int i = 0; i < paramValues.length;i++){
try {
paramValues[i] = URLDecoder.decode(paramValues[i], "UTF-8");
} catch (UnsupportedEncodingException e) {
LOG.warn(e.getMessage(),e);
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/PLUTO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764874#action_12764874
]
Ate Douma commented on PLUTO-579:
---------------------------------
Hi David,
Sorry for not replying any time sooner on your questions.
I agree definitely the current 1.1.x and possibly also the trunk parameter encoding might
not be fully compliant yet and in some areas seems to be unnecessary and excessive indeed.
But I still haven't had time to look deeper into this, nor will I be able to do so this week.
I never really worked on the Pluto 1.1.x code base and for 2.0 only migrated and fixed (the
Pluto *Driver*) code where minimally needed.
If you already have progressed further since your last comment, please let me know: I'd like
to further discuss and help out to get this straightened out.
I'll try to chime back in on this issue next week if possible. If you want, ping me in private
to remind me :)
> Some render parameters are lost if they contains semicolon
> ----------------------------------------------------------
>
> Key: PLUTO-579
> URL: https://issues.apache.org/jira/browse/PLUTO-579
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.7
> Reporter: Ivan
> Assignee: David Jencks
> Fix For: 2.0.1, 1.1.8
>
> Attachments: PLUTO-579-0921.patch, PLUTO-579.patch
>
>
> If one render parameter contains semicolon, those parameters after it in the url are
lost
> Like the URL below
> __pm0x3system-database0x2DBWizard!1134683811|0_view/__rp0x3system-database0x2DBWizard!1134683811|0_rarPath/org0x2tranql0x3tranql-connector-ra0x30x3rar/__rp0x3system-database0x2DBWizard!1134683811|0_driverClass/com0x2microsoft0x2sqlserver0x2jdbc0x2SQLServerDriver/__rp0x3system-database0x2DBWizard!1134683811|0_mode/params/__rp0x3system-database0x2DBWizard!1134683811|0_dbtype/SQL0x8Server0x82005/__rp0x3system-database0x2DBWizard!1134683811|0_adapterDisplayName/TranQL0x8Generic0x8JDBC0x8Resource0x8Adapter/__rp0x3system-database0x2DBWizard!1134683811|0_urlPrototype/jdbc:sqlserver:0x30x3%7BHost%7D:%7BPort%7D;DatabaseName=%7BDatabase%7D/__rp0x3system-database0x2DBWizard!1134683811|0_transactionType/LOCAL/__rp0x3system-database0x2DBWizard!1134683811|0_name/ddddd
> The parameter urlPrototype contains semicolon, while I calling renderRequest.getParameter("name"),
it will return null.
> After some investigations, I found in the class PortalURLParserImpl, line 115
> String pathInfo = request.getPathInfo(); <--- the pathInfo got from the request
is truncated by the semicolon.
> if (pathInfo == null) {
> Maybe, we need to add the ; to the ENCODINGS arrays ?
> Thanks !
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/PLUTO-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Woonsan Ko resolved PLUTO-580.
------------------------------
Resolution: Fixed
Fixed by adjusting namespace uris in a custom XmlStreamReader based on the version attribute
of the root element.
I will appreciate for any reviews and comments. Thanks.
> Allow portlet descriptor with empty namesapce during deployment.
> ----------------------------------------------------------------
>
> Key: PLUTO-580
> URL: https://issues.apache.org/jira/browse/PLUTO-580
> Project: Pluto
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Woonsan Ko
> Assignee: Woonsan Ko
> Fix For: 2.0.1
>
>
> Currently, PortletAppDescriptorServiceImpl is using explicit schema based JAXB unmarshalling.
(.../portlet-app_1_0.xsd or .../portlet-app_2_0.xsd).
> However, if we allow empty namespaced descriptor as well, then I think it would be very
convenient.
> Because "version" attribute of portlet-app element is required one, we can infer its
implicit namespaces.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Something obviously went wrong... but you'll need to provide more clues for anyone to be able to help you... any exceptions anywhere? Pavel On Fri, Jul 17, 2009 at 1:15 AM, KetanNale <ketan_nale@yahoo.com> wrote: > > Hi All, > > I am new to portlets. I want to develop portal for my site. > I downloaded Pluto 2.0 source and built but > as per guided on home site > http://localhost:8080/pluto/portal didnt started.... > > can anyone help me how to start with pluto... > > cheers, > -- > View this message in context: > http://www.nabble.com/Getting-Started-tp24529702p24529702.html > Sent from the Pluto - Dev mailing list archive at Nabble.com. > >
Hi Ate, I think there are still issues.... I added another comment to the issue. thanks david jencks On Sep 24, 2009, at 12:56 AM, Ate Douma wrote: > Hi David, > > I looked briefly at both the PLUTO-579 patch and the current Pluto > trunk PortalURLParserImpl and don't think this issue applies to > trunk anymore. > I added a more detailed comment on the issue itself: https://issues.apache.org/jira/browse/PLUTO-579 > > Regards, > > Ate > > David Jencks wrote: >> In geronimo we've had some problems with ';' not getting escaped in >> some portlet urls, see PLUTO-579. The escaping algorithm currently >> used looks really inefficient. One of the Geronimo developers >> (Ivan) came up with a patch that looks good to me and I've applied >> to branches-1.1.x. I think it would be appropriate for trunk as >> well, the code looks about the same. >> Could one of the pluto devs more familiar with this area take a >> look and make sure I'm not missing the point before I go ahead any >> apply it to trunk? >> many thanks >> david jencks >
[ https://issues.apache.org/jira/browse/PLUTO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759215#action_12759215
]
David Jencks commented on PLUTO-579:
------------------------------------
Hi Ate,
I now have a lot of questions :-)
As you note, in trunk both single parameters and multi valued parameters are URLEncoded/Decoded
whereas in 1.1.x only single valued paramters were. I think that clearly by the spec (1.0
spec, top of p 32) the multivalued parameters need to be URL encoded/decoded as well in 1.1.x,
in other words both before and after the 1.1.x change it's not spec compliant.
What I don't understand is why encodeCharacters is needed at all, and why we can't always
use the URLEncoded/Decoder.
trunk encodes these characters:
{code}
private static final String[][] ENCODINGS = new String[][] {
new String[] { "_", "0x1" },
new String[] { ".", "0x2" },
new String[] { "/", "0x3" },
new String[] { "\r", "0x4" },
new String[] { "\n", "0x5" },
new String[] { "<", "0x6" },
new String[] { ">", "0x7" },
new String[] { " ", "0x8" },
new String[] { "#", "0x9" },
new String[] { "?", "0xa" },
new String[] { "\\", "0xb" },
new String[] { "%", "0xc" },
};
{code}
The URLEncoder docs say everything except these get URL encoded:
# The special characters ".", "-", "*", and "_" remain the same.
"." and "_" are pluto-encoded, "-" and "*" are not.
pluto encodeCharacters is called:
after url-encoding multi values. (line 434) This will encode "." and "_" in parameter values.
I don't think this is compliant with the spec.
to encode a windowId (encodeControlParameter, line 395). Is there a regex or similar grammar
for window Ids?
to encode a resourceWindow (toString, line 239). I think this is another windowId.
to encode the actionWindow (toString, line 248), presumably another windowId.
to encode resource window cachablilty (toString, line 256). The ResourceURL seems to indicate
that the valid cachability values are in a small set of string constants. none of which need
encoding.
to encode resource window resourceId (toString, line 261), presumably another windowId.
So, depending on what valid windowIds are, the encoding is unnecessary, excessive, or incomplete.
I'd like to know what valid windowIds can be.
Also, there's a problem with strings to be encoded that have the encoding characters in them
already, such as "0x1". These need to be re-encoded somehow so decoding produces the original
value. I think Ivan's patch does this successfully.
I'll change the branch impl to use more URLEncoding on multi-values, for the other bits I
need more info.
> Some render parameters are lost if they contains semicolon
> ----------------------------------------------------------
>
> Key: PLUTO-579
> URL: https://issues.apache.org/jira/browse/PLUTO-579
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.7
> Reporter: Ivan
> Assignee: David Jencks
> Fix For: 2.0.1, 1.1.8
>
> Attachments: PLUTO-579-0921.patch, PLUTO-579.patch
>
>
> If one render parameter contains semicolon, those parameters after it in the url are
lost
> Like the URL below
> __pm0x3system-database0x2DBWizard!1134683811|0_view/__rp0x3system-database0x2DBWizard!1134683811|0_rarPath/org0x2tranql0x3tranql-connector-ra0x30x3rar/__rp0x3system-database0x2DBWizard!1134683811|0_driverClass/com0x2microsoft0x2sqlserver0x2jdbc0x2SQLServerDriver/__rp0x3system-database0x2DBWizard!1134683811|0_mode/params/__rp0x3system-database0x2DBWizard!1134683811|0_dbtype/SQL0x8Server0x82005/__rp0x3system-database0x2DBWizard!1134683811|0_adapterDisplayName/TranQL0x8Generic0x8JDBC0x8Resource0x8Adapter/__rp0x3system-database0x2DBWizard!1134683811|0_urlPrototype/jdbc:sqlserver:0x30x3%7BHost%7D:%7BPort%7D;DatabaseName=%7BDatabase%7D/__rp0x3system-database0x2DBWizard!1134683811|0_transactionType/LOCAL/__rp0x3system-database0x2DBWizard!1134683811|0_name/ddddd
> The parameter urlPrototype contains semicolon, while I calling renderRequest.getParameter("name"),
it will return null.
> After some investigations, I found in the class PortalURLParserImpl, line 115
> String pathInfo = request.getPathInfo(); <--- the pathInfo got from the request
is truncated by the semicolon.
> if (pathInfo == null) {
> Maybe, we need to add the ; to the ENCODINGS arrays ?
> Thanks !
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Hi David, I looked briefly at both the PLUTO-579 patch and the current Pluto trunk PortalURLParserImpl and don't think this issue applies to trunk anymore. I added a more detailed comment on the issue itself: https://issues.apache.org/jira/browse/PLUTO-579 Regards, Ate David Jencks wrote: > In geronimo we've had some problems with ';' not getting escaped in some > portlet urls, see PLUTO-579. The escaping algorithm currently used > looks really inefficient. One of the Geronimo developers (Ivan) came up > with a patch that looks good to me and I've applied to branches-1.1.x. > I think it would be appropriate for trunk as well, the code looks about > the same. > > Could one of the pluto devs more familiar with this area take a look and > make sure I'm not missing the point before I go ahead any apply it to > trunk? > > many thanks > david jencks >
[ https://issues.apache.org/jira/browse/PLUTO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759053#action_12759053
]
Ate Douma commented on PLUTO-579:
---------------------------------
Hi David,
I looked briefly at both the patch and the current Pluto trunk PortalURLParserImpl.
While a lot of the code still looks the same, there is one major difference: in trunk parameters
are first passed through URLEncoder/URLDecoder before/after the custom encoding/decoding is
done like in Pluto 1.1.x.
As URLEncoder already takes care of ';' characters I think this issue no longer applies to
trunk anymore.
And it seems to me the custom encoding/decoding on trunk could actually now ignore some of
the characters currently defined in the ENCODINGS array.
If using URLEncoder/URLDecoder is as efficient as the new custom encoding/decoding in Pluto
1.1.x branch I don't know.
So, for performance reasons, it might be interested to review if we should replace the trunk
code with this one, but functionally I don't think its needed anymore.
> Some render parameters are lost if they contains semicolon
> ----------------------------------------------------------
>
> Key: PLUTO-579
> URL: https://issues.apache.org/jira/browse/PLUTO-579
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.7
> Reporter: Ivan
> Assignee: David Jencks
> Fix For: 2.0.1, 1.1.8
>
> Attachments: PLUTO-579-0921.patch, PLUTO-579.patch
>
>
> If one render parameter contains semicolon, those parameters after it in the url are
lost
> Like the URL below
> __pm0x3system-database0x2DBWizard!1134683811|0_view/__rp0x3system-database0x2DBWizard!1134683811|0_rarPath/org0x2tranql0x3tranql-connector-ra0x30x3rar/__rp0x3system-database0x2DBWizard!1134683811|0_driverClass/com0x2microsoft0x2sqlserver0x2jdbc0x2SQLServerDriver/__rp0x3system-database0x2DBWizard!1134683811|0_mode/params/__rp0x3system-database0x2DBWizard!1134683811|0_dbtype/SQL0x8Server0x82005/__rp0x3system-database0x2DBWizard!1134683811|0_adapterDisplayName/TranQL0x8Generic0x8JDBC0x8Resource0x8Adapter/__rp0x3system-database0x2DBWizard!1134683811|0_urlPrototype/jdbc:sqlserver:0x30x3%7BHost%7D:%7BPort%7D;DatabaseName=%7BDatabase%7D/__rp0x3system-database0x2DBWizard!1134683811|0_transactionType/LOCAL/__rp0x3system-database0x2DBWizard!1134683811|0_name/ddddd
> The parameter urlPrototype contains semicolon, while I calling renderRequest.getParameter("name"),
it will return null.
> After some investigations, I found in the class PortalURLParserImpl, line 115
> String pathInfo = request.getPathInfo(); <--- the pathInfo got from the request
is truncated by the semicolon.
> if (pathInfo == null) {
> Maybe, we need to add the ; to the ENCODINGS arrays ?
> Thanks !
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
In geronimo we've had some problems with ';' not getting escaped in some portlet urls, see PLUTO-579. The escaping algorithm currently used looks really inefficient. One of the Geronimo developers (Ivan) came up with a patch that looks good to me and I've applied to branches-1.1.x. I think it would be appropriate for trunk as well, the code looks about the same. Could one of the pluto devs more familiar with this area take a look and make sure I'm not missing the point before I go ahead any apply it to trunk? many thanks david jencks
[ https://issues.apache.org/jira/browse/PLUTO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jencks updated PLUTO-579:
-------------------------------
Fix Version/s: 1.1.8
2.0.1
I applied this to branches-1.1.x after making it compile with jdk 1.4 settings. (rev 818328).
I think it should be applied to trunk to, but I'll ask on the dev list first to make sure
its appropriate.
> Some render parameters are lost if they contains semicolon
> ----------------------------------------------------------
>
> Key: PLUTO-579
> URL: https://issues.apache.org/jira/browse/PLUTO-579
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.7
> Reporter: Ivan
> Assignee: David Jencks
> Fix For: 2.0.1, 1.1.8
>
> Attachments: PLUTO-579-0921.patch, PLUTO-579.patch
>
>
> If one render parameter contains semicolon, those parameters after it in the url are
lost
> Like the URL below
> __pm0x3system-database0x2DBWizard!1134683811|0_view/__rp0x3system-database0x2DBWizard!1134683811|0_rarPath/org0x2tranql0x3tranql-connector-ra0x30x3rar/__rp0x3system-database0x2DBWizard!1134683811|0_driverClass/com0x2microsoft0x2sqlserver0x2jdbc0x2SQLServerDriver/__rp0x3system-database0x2DBWizard!1134683811|0_mode/params/__rp0x3system-database0x2DBWizard!1134683811|0_dbtype/SQL0x8Server0x82005/__rp0x3system-database0x2DBWizard!1134683811|0_adapterDisplayName/TranQL0x8Generic0x8JDBC0x8Resource0x8Adapter/__rp0x3system-database0x2DBWizard!1134683811|0_urlPrototype/jdbc:sqlserver:0x30x3%7BHost%7D:%7BPort%7D;DatabaseName=%7BDatabase%7D/__rp0x3system-database0x2DBWizard!1134683811|0_transactionType/LOCAL/__rp0x3system-database0x2DBWizard!1134683811|0_name/ddddd
> The parameter urlPrototype contains semicolon, while I calling renderRequest.getParameter("name"),
it will return null.
> After some investigations, I found in the class PortalURLParserImpl, line 115
> String pathInfo = request.getPathInfo(); <--- the pathInfo got from the request
is truncated by the semicolon.
> if (pathInfo == null) {
> Maybe, we need to add the ; to the ENCODINGS arrays ?
> Thanks !
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/PLUTO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jencks reassigned PLUTO-579:
----------------------------------
Assignee: David Jencks
> Some render parameters are lost if they contains semicolon
> ----------------------------------------------------------
>
> Key: PLUTO-579
> URL: https://issues.apache.org/jira/browse/PLUTO-579
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.7
> Reporter: Ivan
> Assignee: David Jencks
> Attachments: PLUTO-579-0921.patch, PLUTO-579.patch
>
>
> If one render parameter contains semicolon, those parameters after it in the url are
lost
> Like the URL below
> __pm0x3system-database0x2DBWizard!1134683811|0_view/__rp0x3system-database0x2DBWizard!1134683811|0_rarPath/org0x2tranql0x3tranql-connector-ra0x30x3rar/__rp0x3system-database0x2DBWizard!1134683811|0_driverClass/com0x2microsoft0x2sqlserver0x2jdbc0x2SQLServerDriver/__rp0x3system-database0x2DBWizard!1134683811|0_mode/params/__rp0x3system-database0x2DBWizard!1134683811|0_dbtype/SQL0x8Server0x82005/__rp0x3system-database0x2DBWizard!1134683811|0_adapterDisplayName/TranQL0x8Generic0x8JDBC0x8Resource0x8Adapter/__rp0x3system-database0x2DBWizard!1134683811|0_urlPrototype/jdbc:sqlserver:0x30x3%7BHost%7D:%7BPort%7D;DatabaseName=%7BDatabase%7D/__rp0x3system-database0x2DBWizard!1134683811|0_transactionType/LOCAL/__rp0x3system-database0x2DBWizard!1134683811|0_name/ddddd
> The parameter urlPrototype contains semicolon, while I calling renderRequest.getParameter("name"),
it will return null.
> After some investigations, I found in the class PortalURLParserImpl, line 115
> String pathInfo = request.getPathInfo(); <--- the pathInfo got from the request
is truncated by the semicolon.
> if (pathInfo == null) {
> Maybe, we need to add the ; to the ENCODINGS arrays ?
> Thanks !
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/PLUTO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan updated PLUTO-579:
-----------------------
Attachment: PLUTO-579-0921.patch
Attach a updated patch, including a fix about the dupliate slash while contrcuting the url.
This may causes some issues while working with Jetty while the compactpath attribute is set
with false.
> Some render parameters are lost if they contains semicolon
> ----------------------------------------------------------
>
> Key: PLUTO-579
> URL: https://issues.apache.org/jira/browse/PLUTO-579
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.7
> Reporter: Ivan
> Attachments: PLUTO-579-0921.patch, PLUTO-579.patch
>
>
> If one render parameter contains semicolon, those parameters after it in the url are
lost
> Like the URL below
> __pm0x3system-database0x2DBWizard!1134683811|0_view/__rp0x3system-database0x2DBWizard!1134683811|0_rarPath/org0x2tranql0x3tranql-connector-ra0x30x3rar/__rp0x3system-database0x2DBWizard!1134683811|0_driverClass/com0x2microsoft0x2sqlserver0x2jdbc0x2SQLServerDriver/__rp0x3system-database0x2DBWizard!1134683811|0_mode/params/__rp0x3system-database0x2DBWizard!1134683811|0_dbtype/SQL0x8Server0x82005/__rp0x3system-database0x2DBWizard!1134683811|0_adapterDisplayName/TranQL0x8Generic0x8JDBC0x8Resource0x8Adapter/__rp0x3system-database0x2DBWizard!1134683811|0_urlPrototype/jdbc:sqlserver:0x30x3%7BHost%7D:%7BPort%7D;DatabaseName=%7BDatabase%7D/__rp0x3system-database0x2DBWizard!1134683811|0_transactionType/LOCAL/__rp0x3system-database0x2DBWizard!1134683811|0_name/ddddd
> The parameter urlPrototype contains semicolon, while I calling renderRequest.getParameter("name"),
it will return null.
> After some investigations, I found in the class PortalURLParserImpl, line 115
> String pathInfo = request.getPathInfo(); <--- the pathInfo got from the request
is truncated by the semicolon.
> if (pathInfo == null) {
> Maybe, we need to add the ; to the ENCODINGS arrays ?
> Thanks !
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Allow portlet descriptor with empty namesapce during deployment.
----------------------------------------------------------------
Key: PLUTO-580
URL: https://issues.apache.org/jira/browse/PLUTO-580
Project: Pluto
Issue Type: Improvement
Affects Versions: 2.0.0
Reporter: Woonsan Ko
Assignee: Woonsan Ko
Fix For: 2.0.1
Currently, PortletAppDescriptorServiceImpl is using explicit schema based JAXB unmarshalling.
(.../portlet-app_1_0.xsd or .../portlet-app_2_0.xsd).
However, if we allow empty namespaced descriptor as well, then I think it would be very convenient.
Because "version" attribute of portlet-app element is required one, we can infer its implicit
namespaces.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/PLUTO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan updated PLUTO-579:
-----------------------
Attachment: PLUTO-579.patch
Attach a new patch, it includes:
a. Use pattern to encode/decode parameter values
b. Add semicolon to the escape arrays
c. Add codes to handle 0x0" (which is used to separate multiple parameter values) is contained
in the parameter value
Please help to review the patch, thanks !
> Some render parameters are lost if they contains semicolon
> ----------------------------------------------------------
>
> Key: PLUTO-579
> URL: https://issues.apache.org/jira/browse/PLUTO-579
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.7
> Reporter: Ivan
> Attachments: PLUTO-579.patch
>
>
> If one render parameter contains semicolon, those parameters after it in the url are
lost
> Like the URL below
> __pm0x3system-database0x2DBWizard!1134683811|0_view/__rp0x3system-database0x2DBWizard!1134683811|0_rarPath/org0x2tranql0x3tranql-connector-ra0x30x3rar/__rp0x3system-database0x2DBWizard!1134683811|0_driverClass/com0x2microsoft0x2sqlserver0x2jdbc0x2SQLServerDriver/__rp0x3system-database0x2DBWizard!1134683811|0_mode/params/__rp0x3system-database0x2DBWizard!1134683811|0_dbtype/SQL0x8Server0x82005/__rp0x3system-database0x2DBWizard!1134683811|0_adapterDisplayName/TranQL0x8Generic0x8JDBC0x8Resource0x8Adapter/__rp0x3system-database0x2DBWizard!1134683811|0_urlPrototype/jdbc:sqlserver:0x30x3%7BHost%7D:%7BPort%7D;DatabaseName=%7BDatabase%7D/__rp0x3system-database0x2DBWizard!1134683811|0_transactionType/LOCAL/__rp0x3system-database0x2DBWizard!1134683811|0_name/ddddd
> The parameter urlPrototype contains semicolon, while I calling renderRequest.getParameter("name"),
it will return null.
> After some investigations, I found in the class PortalURLParserImpl, line 115
> String pathInfo = request.getPathInfo(); <--- the pathInfo got from the request
is truncated by the semicolon.
> if (pathInfo == null) {
> Maybe, we need to add the ; to the ENCODINGS arrays ?
> Thanks !
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/PLUTO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan updated PLUTO-579:
-----------------------
Attachment: (was: PLUTO-579.patch)
> Some render parameters are lost if they contains semicolon
> ----------------------------------------------------------
>
> Key: PLUTO-579
> URL: https://issues.apache.org/jira/browse/PLUTO-579
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.7
> Reporter: Ivan
>
> If one render parameter contains semicolon, those parameters after it in the url are
lost
> Like the URL below
> __pm0x3system-database0x2DBWizard!1134683811|0_view/__rp0x3system-database0x2DBWizard!1134683811|0_rarPath/org0x2tranql0x3tranql-connector-ra0x30x3rar/__rp0x3system-database0x2DBWizard!1134683811|0_driverClass/com0x2microsoft0x2sqlserver0x2jdbc0x2SQLServerDriver/__rp0x3system-database0x2DBWizard!1134683811|0_mode/params/__rp0x3system-database0x2DBWizard!1134683811|0_dbtype/SQL0x8Server0x82005/__rp0x3system-database0x2DBWizard!1134683811|0_adapterDisplayName/TranQL0x8Generic0x8JDBC0x8Resource0x8Adapter/__rp0x3system-database0x2DBWizard!1134683811|0_urlPrototype/jdbc:sqlserver:0x30x3%7BHost%7D:%7BPort%7D;DatabaseName=%7BDatabase%7D/__rp0x3system-database0x2DBWizard!1134683811|0_transactionType/LOCAL/__rp0x3system-database0x2DBWizard!1134683811|0_name/ddddd
> The parameter urlPrototype contains semicolon, while I calling renderRequest.getParameter("name"),
it will return null.
> After some investigations, I found in the class PortalURLParserImpl, line 115
> String pathInfo = request.getPathInfo(); <--- the pathInfo got from the request
is truncated by the semicolon.
> if (pathInfo == null) {
> Maybe, we need to add the ; to the ENCODINGS arrays ?
> Thanks !
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/PLUTO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755268#action_12755268
]
David Jencks commented on PLUTO-579:
------------------------------------
Can we use a similar regular expression to do the encoding as well as the decoding?
> Some render parameters are lost if they contains semicolon
> ----------------------------------------------------------
>
> Key: PLUTO-579
> URL: https://issues.apache.org/jira/browse/PLUTO-579
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.7
> Reporter: Ivan
> Attachments: PLUTO-579.patch
>
>
> If one render parameter contains semicolon, those parameters after it in the url are
lost
> Like the URL below
> __pm0x3system-database0x2DBWizard!1134683811|0_view/__rp0x3system-database0x2DBWizard!1134683811|0_rarPath/org0x2tranql0x3tranql-connector-ra0x30x3rar/__rp0x3system-database0x2DBWizard!1134683811|0_driverClass/com0x2microsoft0x2sqlserver0x2jdbc0x2SQLServerDriver/__rp0x3system-database0x2DBWizard!1134683811|0_mode/params/__rp0x3system-database0x2DBWizard!1134683811|0_dbtype/SQL0x8Server0x82005/__rp0x3system-database0x2DBWizard!1134683811|0_adapterDisplayName/TranQL0x8Generic0x8JDBC0x8Resource0x8Adapter/__rp0x3system-database0x2DBWizard!1134683811|0_urlPrototype/jdbc:sqlserver:0x30x3%7BHost%7D:%7BPort%7D;DatabaseName=%7BDatabase%7D/__rp0x3system-database0x2DBWizard!1134683811|0_transactionType/LOCAL/__rp0x3system-database0x2DBWizard!1134683811|0_name/ddddd
> The parameter urlPrototype contains semicolon, while I calling renderRequest.getParameter("name"),
it will return null.
> After some investigations, I found in the class PortalURLParserImpl, line 115
> String pathInfo = request.getPathInfo(); <--- the pathInfo got from the request
is truncated by the semicolon.
> if (pathInfo == null) {
> Maybe, we need to add the ; to the ENCODINGS arrays ?
> Thanks !
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/PLUTO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan updated PLUTO-579:
-----------------------
Attachment: PLUTO-579.patch
Thanks for the comment, David, I re-created a new patch.
> Some render parameters are lost if they contains semicolon
> ----------------------------------------------------------
>
> Key: PLUTO-579
> URL: https://issues.apache.org/jira/browse/PLUTO-579
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.7
> Reporter: Ivan
> Attachments: PLUTO-579.patch
>
>
> If one render parameter contains semicolon, those parameters after it in the url are
lost
> Like the URL below
> __pm0x3system-database0x2DBWizard!1134683811|0_view/__rp0x3system-database0x2DBWizard!1134683811|0_rarPath/org0x2tranql0x3tranql-connector-ra0x30x3rar/__rp0x3system-database0x2DBWizard!1134683811|0_driverClass/com0x2microsoft0x2sqlserver0x2jdbc0x2SQLServerDriver/__rp0x3system-database0x2DBWizard!1134683811|0_mode/params/__rp0x3system-database0x2DBWizard!1134683811|0_dbtype/SQL0x8Server0x82005/__rp0x3system-database0x2DBWizard!1134683811|0_adapterDisplayName/TranQL0x8Generic0x8JDBC0x8Resource0x8Adapter/__rp0x3system-database0x2DBWizard!1134683811|0_urlPrototype/jdbc:sqlserver:0x30x3%7BHost%7D:%7BPort%7D;DatabaseName=%7BDatabase%7D/__rp0x3system-database0x2DBWizard!1134683811|0_transactionType/LOCAL/__rp0x3system-database0x2DBWizard!1134683811|0_name/ddddd
> The parameter urlPrototype contains semicolon, while I calling renderRequest.getParameter("name"),
it will return null.
> After some investigations, I found in the class PortalURLParserImpl, line 115
> String pathInfo = request.getPathInfo(); <--- the pathInfo got from the request
is truncated by the semicolon.
> if (pathInfo == null) {
> Maybe, we need to add the ; to the ENCODINGS arrays ?
> Thanks !
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/PLUTO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan updated PLUTO-579:
-----------------------
Attachment: (was: PLUTO-579.patch)
> Some render parameters are lost if they contains semicolon
> ----------------------------------------------------------
>
> Key: PLUTO-579
> URL: https://issues.apache.org/jira/browse/PLUTO-579
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.7
> Reporter: Ivan
>
> If one render parameter contains semicolon, those parameters after it in the url are
lost
> Like the URL below
> __pm0x3system-database0x2DBWizard!1134683811|0_view/__rp0x3system-database0x2DBWizard!1134683811|0_rarPath/org0x2tranql0x3tranql-connector-ra0x30x3rar/__rp0x3system-database0x2DBWizard!1134683811|0_driverClass/com0x2microsoft0x2sqlserver0x2jdbc0x2SQLServerDriver/__rp0x3system-database0x2DBWizard!1134683811|0_mode/params/__rp0x3system-database0x2DBWizard!1134683811|0_dbtype/SQL0x8Server0x82005/__rp0x3system-database0x2DBWizard!1134683811|0_adapterDisplayName/TranQL0x8Generic0x8JDBC0x8Resource0x8Adapter/__rp0x3system-database0x2DBWizard!1134683811|0_urlPrototype/jdbc:sqlserver:0x30x3%7BHost%7D:%7BPort%7D;DatabaseName=%7BDatabase%7D/__rp0x3system-database0x2DBWizard!1134683811|0_transactionType/LOCAL/__rp0x3system-database0x2DBWizard!1134683811|0_name/ddddd
> The parameter urlPrototype contains semicolon, while I calling renderRequest.getParameter("name"),
it will return null.
> After some investigations, I found in the class PortalURLParserImpl, line 115
> String pathInfo = request.getPathInfo(); <--- the pathInfo got from the request
is truncated by the semicolon.
> if (pathInfo == null) {
> Maybe, we need to add the ; to the ENCODINGS arrays ?
> Thanks !
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/PLUTO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754439#action_12754439
]
David Jencks commented on PLUTO-579:
------------------------------------
I think there must be a way to only scan through the string once for encoding or decoding.
Can we do each operation using only one regular expression?
> Some render parameters are lost if they contains semicolon
> ----------------------------------------------------------
>
> Key: PLUTO-579
> URL: https://issues.apache.org/jira/browse/PLUTO-579
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.7
> Reporter: Ivan
> Attachments: PLUTO-579.patch
>
>
> If one render parameter contains semicolon, those parameters after it in the url are
lost
> Like the URL below
> __pm0x3system-database0x2DBWizard!1134683811|0_view/__rp0x3system-database0x2DBWizard!1134683811|0_rarPath/org0x2tranql0x3tranql-connector-ra0x30x3rar/__rp0x3system-database0x2DBWizard!1134683811|0_driverClass/com0x2microsoft0x2sqlserver0x2jdbc0x2SQLServerDriver/__rp0x3system-database0x2DBWizard!1134683811|0_mode/params/__rp0x3system-database0x2DBWizard!1134683811|0_dbtype/SQL0x8Server0x82005/__rp0x3system-database0x2DBWizard!1134683811|0_adapterDisplayName/TranQL0x8Generic0x8JDBC0x8Resource0x8Adapter/__rp0x3system-database0x2DBWizard!1134683811|0_urlPrototype/jdbc:sqlserver:0x30x3%7BHost%7D:%7BPort%7D;DatabaseName=%7BDatabase%7D/__rp0x3system-database0x2DBWizard!1134683811|0_transactionType/LOCAL/__rp0x3system-database0x2DBWizard!1134683811|0_name/ddddd
> The parameter urlPrototype contains semicolon, while I calling renderRequest.getParameter("name"),
it will return null.
> After some investigations, I found in the class PortalURLParserImpl, line 115
> String pathInfo = request.getPathInfo(); <--- the pathInfo got from the request
is truncated by the semicolon.
> if (pathInfo == null) {
> Maybe, we need to add the ; to the ENCODINGS arrays ?
> Thanks !
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Woonsan Ko wrote: > > So, I'm inclined to support that case as well because it is mentioned as *not required*. > Great, so +1 to the whole thing. Regards Carsten -- Carsten Ziegeler cziegeler@apache.org
Woonsan Ko wrote:
> Hi Carsten,
>
>
> --- On Thu, 9/10/09, Carsten Ziegeler <cziegeler@apache.org> wrote:
>
>> From: Carsten Ziegeler <cziegeler@apache.org>
>> Subject: Re: How about allowing empty namespaced portlet descriptor?
>> To: pluto-dev@portals.apache.org
>> Date: Thursday, September 10, 2009, 5:39 PM
>> Now, while I think that a portlet.xml
>> which does not use use the
>> namespace is not valid (wrt the spec), it sounds reasonable
>> to
>> support such descriptors.
>> And I also agree that this support makes sense in Pluto.
>>
>> The only question I have which cases we support :)
>> The example below mentions: <portlet-app id="charttest"
>> version="1.0">.
>> This can be supported easily.
>> Two questions:
>> - I guess the version attribute is still mandatory, right?
>
> Right. I've just found that the xsd says it is a required attribute.
>
>> - What happens if someone is using <portlet-app
>> id="charttest"
>> version="2.0">? Would we support that as well?
>
> Good point. I haven't thought of it. :-)
> I found the following in the section, "PLT.25.4 Rules for processing the Portlet Deployment
Descriptor", of the spec:
>
> "It is recommended, but not required, that portlet containers and tools validate both
deployment descriptors against the corresponding DTD and XML Schema definitions for structural
correctness."
>
> So, I'm inclined to support that case as well because it is mentioned as *not required*.
+1 from me on all of this.
Regards,
Ate
>
>
> Regards,
>
> Woonsan
>
>
>> Regards
>> Carsten
>>
>> Woonsan Ko wrote:
>>> Hi there,
>>>
>>> During testing portlet deployments with some useful
>> PAs from jp.sf.pal portlet repository, I found that the
>> current pluto-2 deployment component failed to deploy a PA
>> when the descriptor of the PA does not have any namespace
>> uri definition with the following exceptions:
>>> java.io.IOException: unexpected element
>>> (uri:"", local:"portlet-app"). Expected elements are
>>> <{http://java.sun.com/xml/ns/portlet/portlet-app_1_0.xsd}portlet-app>,<{http://java.sun.com/xml/ns/portlet/portlet-app_2_0.xsd}portlet-app>
>>>
>>> The portlet.xml is like the following:
>>>
>>> <?xml version="1.0" encoding="UTF-8"?>
>>> <portlet-app id="charttest" version="1.0">
>>> <snip/>
>>> </portlet-app>
>>>
>>> It's simply because PortletAppDescriptorServiceImpl is
>> using explicit schema based JAXB unmarshalling.
>> (.../portlet-app_1_0.xsd or .../portlet-app_2_0.xsd)
>>> However, if we allow empty namespaced descriptor as
>> well, then I think it would be very helpful to deploy some
>> old portlet-1.0 based existing portlet applications.
>>> To do this without any side effect, we can just copy
>> the portlet 1.0 JAXB package,
>> "o.a.p.container.om.portlet10.impl", to a new package (such
>> as "o.a.p.container.om.portlet10.emptyns.impl"?), with
>> empty namespace annotations and add it into the JAXB context
>> as a third option in the PortletAppDescriptorService
>> implementation.
>>> By the way, this feature has been recently committed
>> in Jetspeed-2.2.1-SNAPSHOT, but I'm now thinking it would be
>> better to move this to pluto.
>>> You can see the issue (JS2-1061) and the related
>> discussion here:
>>> http://www.nabble.com/On-the-current-strong-validation-during-PA-deployment-td25261119.html
>>>
>>> If there's no objection, I hope to add this to pluto
>> trunk.
>>> What do you think?
>>>
>>>
>>> Kind regards,
>>>
>>> Woonsan
>>>
>>>
>>>
>>>
>>>
>>
>> --
>> Carsten Ziegeler
>> cziegeler@apache.org
>>
>
>
>
Hi Carsten,
--- On Thu, 9/10/09, Carsten Ziegeler <cziegeler@apache.org> wrote:
> From: Carsten Ziegeler <cziegeler@apache.org>
> Subject: Re: How about allowing empty namespaced portlet descriptor?
> To: pluto-dev@portals.apache.org
> Date: Thursday, September 10, 2009, 5:39 PM
> Now, while I think that a portlet.xml
> which does not use use the
> namespace is not valid (wrt the spec), it sounds reasonable
> to
> support such descriptors.
> And I also agree that this support makes sense in Pluto.
>
> The only question I have which cases we support :)
> The example below mentions: <portlet-app id="charttest"
> version="1.0">.
> This can be supported easily.
> Two questions:
> - I guess the version attribute is still mandatory, right?
Right. I've just found that the xsd says it is a required attribute.
> - What happens if someone is using <portlet-app
> id="charttest"
> version="2.0">? Would we support that as well?
Good point. I haven't thought of it. :-)
I found the following in the section, "PLT.25.4 Rules for processing the Portlet Deployment
Descriptor", of the spec:
"It is recommended, but not required, that portlet containers and tools validate both deployment
descriptors against the corresponding DTD and XML Schema definitions for structural correctness."
So, I'm inclined to support that case as well because it is mentioned as *not required*.
Regards,
Woonsan
>
> Regards
> Carsten
>
> Woonsan Ko wrote:
> > Hi there,
> >
> > During testing portlet deployments with some useful
> PAs from jp.sf.pal portlet repository, I found that the
> current pluto-2 deployment component failed to deploy a PA
> when the descriptor of the PA does not have any namespace
> uri definition with the following exceptions:
> >
> > java.io.IOException: unexpected element
> > (uri:"", local:"portlet-app"). Expected elements are
> > <{http://java.sun.com/xml/ns/portlet/portlet-app_1_0.xsd}portlet-app>,<{http://java.sun.com/xml/ns/portlet/portlet-app_2_0.xsd}portlet-app>
> >
> > The portlet.xml is like the following:
> >
> > <?xml version="1.0" encoding="UTF-8"?>
> > <portlet-app id="charttest" version="1.0">
> > <snip/>
> > </portlet-app>
> >
> > It's simply because PortletAppDescriptorServiceImpl is
> using explicit schema based JAXB unmarshalling.
> (.../portlet-app_1_0.xsd or .../portlet-app_2_0.xsd)
> >
> > However, if we allow empty namespaced descriptor as
> well, then I think it would be very helpful to deploy some
> old portlet-1.0 based existing portlet applications.
> >
> > To do this without any side effect, we can just copy
> the portlet 1.0 JAXB package,
> "o.a.p.container.om.portlet10.impl", to a new package (such
> as "o.a.p.container.om.portlet10.emptyns.impl"?), with
> empty namespace annotations and add it into the JAXB context
> as a third option in the PortletAppDescriptorService
> implementation.
> >
> > By the way, this feature has been recently committed
> in Jetspeed-2.2.1-SNAPSHOT, but I'm now thinking it would be
> better to move this to pluto.
> > You can see the issue (JS2-1061) and the related
> discussion here:
> > http://www.nabble.com/On-the-current-strong-validation-during-PA-deployment-td25261119.html
> >
> > If there's no objection, I hope to add this to pluto
> trunk.
> > What do you think?
> >
> >
> > Kind regards,
> >
> > Woonsan
> >
> >
> >
> >
> >
>
>
> --
> Carsten Ziegeler
> cziegeler@apache.org
>
Now, while I think that a portlet.xml which does not use use the
namespace is not valid (wrt the spec), it sounds reasonable to
support such descriptors.
And I also agree that this support makes sense in Pluto.
The only question I have which cases we support :)
The example below mentions: <portlet-app id="charttest" version="1.0">.
This can be supported easily.
Two questions:
- I guess the version attribute is still mandatory, right?
- What happens if someone is using <portlet-app id="charttest"
version="2.0">? Would we support that as well?
Regards
Carsten
Woonsan Ko wrote:
> Hi there,
>
> During testing portlet deployments with some useful PAs from jp.sf.pal portlet repository,
I found that the current pluto-2 deployment component failed to deploy a PA when the descriptor
of the PA does not have any namespace uri definition with the following exceptions:
>
> java.io.IOException: unexpected element
> (uri:"", local:"portlet-app"). Expected elements are
> <{http://java.sun.com/xml/ns/portlet/portlet-app_1_0.xsd}portlet-app>,<{http://java.sun.com/xml/ns/portlet/portlet-app_2_0.xsd}portlet-app>
>
> The portlet.xml is like the following:
>
> <?xml version="1.0" encoding="UTF-8"?>
> <portlet-app id="charttest" version="1.0">
> <snip/>
> </portlet-app>
>
> It's simply because PortletAppDescriptorServiceImpl is using explicit schema based JAXB
unmarshalling. (.../portlet-app_1_0.xsd or .../portlet-app_2_0.xsd)
>
> However, if we allow empty namespaced descriptor as well, then I think it would be very
helpful to deploy some old portlet-1.0 based existing portlet applications.
>
> To do this without any side effect, we can just copy the portlet 1.0 JAXB package, "o.a.p.container.om.portlet10.impl",
to a new package (such as "o.a.p.container.om.portlet10.emptyns.impl"?), with empty namespace
annotations and add it into the JAXB context as a third option in the PortletAppDescriptorService
implementation.
>
> By the way, this feature has been recently committed in Jetspeed-2.2.1-SNAPSHOT, but
I'm now thinking it would be better to move this to pluto.
> You can see the issue (JS2-1061) and the related discussion here:
> http://www.nabble.com/On-the-current-strong-validation-during-PA-deployment-td25261119.html
>
> If there's no objection, I hope to add this to pluto trunk.
> What do you think?
>
>
> Kind regards,
>
> Woonsan
>
>
>
>
>
--
Carsten Ziegeler
cziegeler@apache.org
Hi there,
During testing portlet deployments with some useful PAs from jp.sf.pal portlet repository,
I found that the current pluto-2 deployment component failed to deploy a PA when the descriptor
of the PA does not have any namespace uri definition with the following exceptions:
java.io.IOException: unexpected element
(uri:"", local:"portlet-app"). Expected elements are
<{http://java.sun.com/xml/ns/portlet/portlet-app_1_0.xsd}portlet-app>,<{http://java.sun.com/xml/ns/portlet/portlet-app_2_0.xsd}portlet-app>
The portlet.xml is like the following:
<?xml version="1.0" encoding="UTF-8"?>
<portlet-app id="charttest" version="1.0">
<snip/>
</portlet-app>
It's simply because PortletAppDescriptorServiceImpl is using explicit schema based JAXB unmarshalling.
(.../portlet-app_1_0.xsd or .../portlet-app_2_0.xsd)
However, if we allow empty namespaced descriptor as well, then I think it would be very helpful
to deploy some old portlet-1.0 based existing portlet applications.
To do this without any side effect, we can just copy the portlet 1.0 JAXB package, "o.a.p.container.om.portlet10.impl",
to a new package (such as "o.a.p.container.om.portlet10.emptyns.impl"?), with empty namespace
annotations and add it into the JAXB context as a third option in the PortletAppDescriptorService
implementation.
By the way, this feature has been recently committed in Jetspeed-2.2.1-SNAPSHOT, but I'm now
thinking it would be better to move this to pluto.
You can see the issue (JS2-1061) and the related discussion here:
http://www.nabble.com/On-the-current-strong-validation-during-PA-deployment-td25261119.html
If there's no objection, I hope to add this to pluto trunk.
What do you think?
Kind regards,
Woonsan
[ https://issues.apache.org/jira/browse/PLUTO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan updated PLUTO-579:
-----------------------
Attachment: PLUTO-579.patch
I created a patch for it, please help to review, thanks !
The changes include :
1. Add semicolon to the encoding array
2. Add codes to handle those replaced strings, e.g. if the parameter is '0xaabc', make sure
'0xa' is not replaced with ? when decoding the parameter value.
> Some render parameters are lost if they contains semicolon
> ----------------------------------------------------------
>
> Key: PLUTO-579
> URL: https://issues.apache.org/jira/browse/PLUTO-579
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.7
> Reporter: Ivan
> Attachments: PLUTO-579.patch
>
>
> If one render parameter contains semicolon, those parameters after it in the url are
lost
> Like the URL below
> __pm0x3system-database0x2DBWizard!1134683811|0_view/__rp0x3system-database0x2DBWizard!1134683811|0_rarPath/org0x2tranql0x3tranql-connector-ra0x30x3rar/__rp0x3system-database0x2DBWizard!1134683811|0_driverClass/com0x2microsoft0x2sqlserver0x2jdbc0x2SQLServerDriver/__rp0x3system-database0x2DBWizard!1134683811|0_mode/params/__rp0x3system-database0x2DBWizard!1134683811|0_dbtype/SQL0x8Server0x82005/__rp0x3system-database0x2DBWizard!1134683811|0_adapterDisplayName/TranQL0x8Generic0x8JDBC0x8Resource0x8Adapter/__rp0x3system-database0x2DBWizard!1134683811|0_urlPrototype/jdbc:sqlserver:0x30x3%7BHost%7D:%7BPort%7D;DatabaseName=%7BDatabase%7D/__rp0x3system-database0x2DBWizard!1134683811|0_transactionType/LOCAL/__rp0x3system-database0x2DBWizard!1134683811|0_name/ddddd
> The parameter urlPrototype contains semicolon, while I calling renderRequest.getParameter("name"),
it will return null.
> After some investigations, I found in the class PortalURLParserImpl, line 115
> String pathInfo = request.getPathInfo(); <--- the pathInfo got from the request
is truncated by the semicolon.
> if (pathInfo == null) {
> Maybe, we need to add the ; to the ENCODINGS arrays ?
> Thanks !
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Some render parameters are lost if they contains semicolon
----------------------------------------------------------
Key: PLUTO-579
URL: https://issues.apache.org/jira/browse/PLUTO-579
Project: Pluto
Issue Type: Bug
Components: portal driver
Affects Versions: 1.1.7
Reporter: Ivan
If one render parameter contains semicolon, those parameters after it in the url are lost
Like the URL below
__pm0x3system-database0x2DBWizard!1134683811|0_view/__rp0x3system-database0x2DBWizard!1134683811|0_rarPath/org0x2tranql0x3tranql-connector-ra0x30x3rar/__rp0x3system-database0x2DBWizard!1134683811|0_driverClass/com0x2microsoft0x2sqlserver0x2jdbc0x2SQLServerDriver/__rp0x3system-database0x2DBWizard!1134683811|0_mode/params/__rp0x3system-database0x2DBWizard!1134683811|0_dbtype/SQL0x8Server0x82005/__rp0x3system-database0x2DBWizard!1134683811|0_adapterDisplayName/TranQL0x8Generic0x8JDBC0x8Resource0x8Adapter/__rp0x3system-database0x2DBWizard!1134683811|0_urlPrototype/jdbc:sqlserver:0x30x3%7BHost%7D:%7BPort%7D;DatabaseName=%7BDatabase%7D/__rp0x3system-database0x2DBWizard!1134683811|0_transactionType/LOCAL/__rp0x3system-database0x2DBWizard!1134683811|0_name/ddddd
The parameter urlPrototype contains semicolon, while I calling renderRequest.getParameter("name"),
it will return null.
After some investigations, I found in the class PortalURLParserImpl, line 115
String pathInfo = request.getPathInfo(); <--- the pathInfo got from the request
is truncated by the semicolon.
if (pathInfo == null) {
Maybe, we need to add the ; to the ENCODINGS arrays ?
Thanks !
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
pluto-current-bundle not working (Pluto 2.0)
--------------------------------------------
Key: PLUTO-578
URL: https://issues.apache.org/jira/browse/PLUTO-578
Project: Pluto
Issue Type: Bug
Components: portal driver
Affects Versions: 2.0.0
Environment: Windows XP
Reporter: Ben
After following each step of Installing the Pluto 2.0 Binary Build (http://portals.apache.org/pluto/v20/getting-started.html)
I get the following error after logging in:
org.apache.jasper.JasperException: java.lang.RuntimeException: Unable to load Portlet App
Deployment Descriptor:Unable to retrieve portlet: 'pluto/AboutPortlet'
org.apache.jasper.servlet.JspServletWrapper.handleJspException(JspServletWrapper.java:522)
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:416)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:342)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:267)
javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
org.apache.jasper.runtime.JspRuntimeLibrary.include(JspRuntimeLibrary.java:968)
org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspx_meth_c_005fforEach_005f1(pluto_002ddefault_002dtheme_jsp.java:527)
org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspx_meth_c_005fotherwise_005f0(pluto_002ddefault_002dtheme_jsp.java:471)
org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspx_meth_c_005fchoose_005f0(pluto_002ddefault_002dtheme_jsp.java:332)
org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspService(pluto_002ddefault_002dtheme_jsp.java:165)
org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:374)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:342)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:267)
javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
org.apache.pluto.driver.PortalDriverServlet.doGet(PortalDriverServlet.java:189)
javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
java.lang.RuntimeException: Unable to load Portlet App Deployment Descriptor:Unable to retrieve
portlet: 'pluto/AboutPortlet'
org.apache.pluto.driver.core.PortletWindowImpl.<init>(PortletWindowImpl.java:73)
org.apache.pluto.driver.tags.PortletTag.doStartTag(PortletTag.java:128)
org.apache.jsp.WEB_002dINF.themes.portlet_002dskin_jsp._jspService(portlet_002dskin_jsp.java:85)
org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:374)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:342)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:267)
javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
org.apache.jasper.runtime.JspRuntimeLibrary.include(JspRuntimeLibrary.java:968)
org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspx_meth_c_005fforEach_005f1(pluto_002ddefault_002dtheme_jsp.java:527)
org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspx_meth_c_005fotherwise_005f0(pluto_002ddefault_002dtheme_jsp.java:471)
org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspx_meth_c_005fchoose_005f0(pluto_002ddefault_002dtheme_jsp.java:332)
org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspService(pluto_002ddefault_002dtheme_jsp.java:165)
org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:374)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:342)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:267)
javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
org.apache.pluto.driver.PortalDriverServlet.doGet(PortalDriverServlet.java:189)
javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/PLUTO-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748487#action_12748487
]
Gary Weaver commented on PLUTO-576:
-----------------------------------
Note Eric said "Perhaps a better enhancement for uPortal's purpose would be to fail with a
message stating the web.xml should be cleaned out before the deploy tool is used."
> Maven pluto plugin should fail or generate warning if web.xml already contains servlet/servlet-mapping
similar to one being added by maven pluto plugin
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PLUTO-576
> URL: https://issues.apache.org/jira/browse/PLUTO-576
> Project: Pluto
> Issue Type: Improvement
> Components: maven pluto plugin
> Reporter: Gary Weaver
>
> If the web.xml that the plugin is altering already contains a servlet and/or servlet-mapping
element that looks very much like the ones it is adding it should either fail or at least
generate a warning. I know that having the pluto-generated config in the web.xml of the portlet
to be "plutofied" by the plugin is wrong, but if the plugin makes web.xml invalid because
that info already exists, it seems like it should check for it. Please ignore this if it is
an invalid request, but I remembered that it worked this way, it caused problems for at least
a few people developing portlets for uPortal over the past 2 years reported on the JASIG uportal-user/portlet-dev
lists, and Eric Dalquist just mentioned that perhaps this would be a good place to mention
it also since uPortal now uses this plugin. Thanks, guys!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.