portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ate Douma (Updated) (JIRA)" <jetspeed-...@portals.apache.org>
Subject [jira] [Updated] (JS2-1268) File download (fileserver) pipeline is broken since 2.2.1
Date Thu, 06 Oct 2011 00:20:32 GMT

     [ https://issues.apache.org/jira/browse/JS2-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ate Douma updated JS2-1268:
---------------------------

    Priority: Minor  (was: Major)

I looked into this and found the cause of it: this functionality was 'lost' during the introduction
of the DynamicPage support, svn r891420, specifically the changes in o.a.j.profiler.rules.impl.PathSessionResolver.java

Now, it could be pretty easy to 'restore' this functionality, like for example with the following
patch:

  Index: src/main/java/org/apache/jetspeed/aggregator/FileServerValve.java
  ===================================================================
  --- src/main/java/org/apache/jetspeed/aggregator/FileServerValve.java	(revision 1179114)
  +++ src/main/java/org/apache/jetspeed/aggregator/FileServerValve.java	(working copy)
  @@ -63,6 +63,7 @@
               {
                   request.setAttribute(PortalReservedParameters.PORTLET, portletName);
               }        
  +            request.setAttribute(PortalReservedParameters.PATH_ATTRIBUTE, request.getPath());
           }
           catch (Exception e)
           {

This will already work (tested locally).

However, the question is: do we really want to solve it like this and leave it at that?

I've some ideas about this and a possible easy alternative solution in mind, but which I first
want to explore a bit further and come on this sometime later.

At any rate, I think this 'bug' really only is a minor issue, although a bit annoying as it
currently isn't working for both the 2.2.1 and 2.2.2 releases.
I'm therefore lowering the priority of this issue to Minor until further notice.
                
> File download (fileserver) pipeline is broken since 2.2.1
> ---------------------------------------------------------
>
>                 Key: JS2-1268
>                 URL: https://issues.apache.org/jira/browse/JS2-1268
>             Project: Jetspeed 2
>          Issue Type: Bug
>    Affects Versions: 2.2.1
>            Reporter: Woonsan Ko
>            Priority: Minor
>             Fix For: 2.2.3
>
>
> The fileserver pipeline seems to have been broken since 2.2.1. (I couldn't find a download
link to 2.2.0.)
> It works fine with 2.1.4 release when a pdf file is copied into /j2-admin/WEB-INF/_content/en/sample_pdf.pdf.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message