portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Woonsan Ko <woon_...@yahoo.com>
Subject Re: svn commit: r1178716 - /portals/jetspeed-2/portal/trunk/components/jetspeed-page-layout/src/main/java/org/apache/jetspeed/layout/impl/PageLayoutComponentImpl.java
Date Tue, 04 Oct 2011 15:18:33 GMT
Hi David,

I'd like to help with this. I found that the original code was intended to initialize the
security constraints by setting null at first and reset later by kind of aggregating from
the input.
The original code works fine with CastorXmlPageManager in the unit test. (See my commit log
in r1178828)
I will try to improve the test case by using DatabasePageManager as well.

Regards,

Woonsan


----- Original Message -----
> From: "taylor@apache.org" <taylor@apache.org>
> To: jetspeed-dev@portals.apache.org
> Cc: 
> Sent: Tuesday, October 4, 2011 4:13 AM
> Subject: svn commit: r1178716 - /portals/jetspeed-2/portal/trunk/components/jetspeed-page-layout/src/main/java/org/apache/jetspeed/layout/impl/PageLayoutComponentImpl.java
> 
> Author: taylor
> Date: Tue Oct  4 08:13:11 2011
> New Revision: 1178716
> 
> URL: http://svn.apache.org/viewvc?rev=1178716&view=rev
> Log:
> JS2-1259 don't pass in null to constraints
> 
> Modified:
>     
> portals/jetspeed-2/portal/trunk/components/jetspeed-page-layout/src/main/java/org/apache/jetspeed/layout/impl/PageLayoutComponentImpl.java
> 
> Modified: 
> portals/jetspeed-2/portal/trunk/components/jetspeed-page-layout/src/main/java/org/apache/jetspeed/layout/impl/PageLayoutComponentImpl.java
> URL: 
> http://svn.apache.org/viewvc/portals/jetspeed-2/portal/trunk/components/jetspeed-page-layout/src/main/java/org/apache/jetspeed/layout/impl/PageLayoutComponentImpl.java?rev=1178716&r1=1178715&r2=1178716&view=diff
> ==============================================================================
> --- 
> portals/jetspeed-2/portal/trunk/components/jetspeed-page-layout/src/main/java/org/apache/jetspeed/layout/impl/PageLayoutComponentImpl.java

> (original)
> +++ 
> portals/jetspeed-2/portal/trunk/components/jetspeed-page-layout/src/main/java/org/apache/jetspeed/layout/impl/PageLayoutComponentImpl.java

> Tue Oct  4 08:13:11 2011
> @@ -1924,7 +1924,7 @@ public class PageLayoutComponentImpl imp
>              fragment.checkAccess(JetspeedActions.EDIT);            
> 
>              // update fragment preferences and page in page manager
> -            fragment.setSecurityConstraints(null);
> +            fragment.setSecurityConstraints(constraints);
>              if ((constraints != null) && !constraints.isEmpty())
>              {
>                  SecurityConstraints fragmentConstraints = 
> fragment.newSecurityConstraints();
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message