portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From woon...@apache.org
Subject svn commit: r992522 - /portals/jetspeed-2/portal/trunk/components/jetspeed-statistics/src/main/java/org/apache/jetspeed/statistics/impl/PortalStatisticsImpl.java
Date Sat, 04 Sep 2010 02:15:47 GMT
Author: woonsan
Date: Sat Sep  4 02:15:46 2010
New Revision: 992522

URL: http://svn.apache.org/viewvc?rev=992522&view=rev
Log:
Skipping unnecessary executions when all loggings are disabled.

Modified:
    portals/jetspeed-2/portal/trunk/components/jetspeed-statistics/src/main/java/org/apache/jetspeed/statistics/impl/PortalStatisticsImpl.java

Modified: portals/jetspeed-2/portal/trunk/components/jetspeed-statistics/src/main/java/org/apache/jetspeed/statistics/impl/PortalStatisticsImpl.java
URL: http://svn.apache.org/viewvc/portals/jetspeed-2/portal/trunk/components/jetspeed-statistics/src/main/java/org/apache/jetspeed/statistics/impl/PortalStatisticsImpl.java?rev=992522&r1=992521&r2=992522&view=diff
==============================================================================
--- portals/jetspeed-2/portal/trunk/components/jetspeed-statistics/src/main/java/org/apache/jetspeed/statistics/impl/PortalStatisticsImpl.java
(original)
+++ portals/jetspeed-2/portal/trunk/components/jetspeed-statistics/src/main/java/org/apache/jetspeed/statistics/impl/PortalStatisticsImpl.java
Sat Sep  4 02:15:46 2010
@@ -39,8 +39,6 @@ import javax.naming.NamingException;
 import javax.servlet.http.HttpServletRequest;
 import javax.sql.DataSource;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 import org.apache.jetspeed.om.page.ContentPage;
 import org.apache.jetspeed.request.RequestContext;
 import org.apache.jetspeed.statistics.AggregateStatistics;
@@ -48,7 +46,8 @@ import org.apache.jetspeed.statistics.In
 import org.apache.jetspeed.statistics.PortalStatistics;
 import org.apache.jetspeed.statistics.StatisticsQueryCriteria;
 import org.apache.jetspeed.statistics.UserStats;
-import org.springframework.orm.ojb.support.PersistenceBrokerDaoSupport;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * <p>
@@ -59,8 +58,7 @@ import org.springframework.orm.ojb.suppo
  * @author <a href="mailto:taylor@apache.org">David Sean Taylor </a>
  * @version $Id$
  */
-public class PortalStatisticsImpl extends PersistenceBrokerDaoSupport implements
-        PortalStatistics
+public class PortalStatisticsImpl implements PortalStatistics
 {
     /* CLF logger */
     protected final static Logger logger = LoggerFactory.getLogger(PortalStatisticsImpl.class);
@@ -116,6 +114,8 @@ public class PortalStatisticsImpl extend
 
     /* date formatter */
     protected SimpleDateFormat formatter = null;
+    
+    private boolean loggingDisabled;
 
     /**
      * <p>
@@ -133,6 +133,7 @@ public class PortalStatisticsImpl extend
 
         this.logToCLF = logToCLF;
         this.logToDatabase = logToDatabase;
+        this.loggingDisabled = (!logToCLF && !logToDatabase);
         this.maxRecordToFlush_Portlet = maxRecordToFlush_Portal;
         this.maxRecordToFlush_User = maxRecordToFlush_User;
         this.maxRecordToFlush_Page = maxRecordToFlush_Page;
@@ -158,7 +159,9 @@ public class PortalStatisticsImpl extend
     public void logPortletAccess(RequestContext request, String portletName,
             String statusCode, long msElapsedTime)
     {
-
+        if (loggingDisabled)
+            return;
+        
         try
         {
             HttpServletRequest req = request.getRequest();
@@ -304,6 +307,9 @@ public class PortalStatisticsImpl extend
     public void logPageAccess(RequestContext request, String statusCode,
             long msElapsedTime)
     {
+        if (loggingDisabled)
+            return;
+
         try
         {
             HttpServletRequest req = request.getRequest();
@@ -345,6 +351,9 @@ public class PortalStatisticsImpl extend
     public void logUserLogout(String ipAddress, String userName,
             long msSessionLength)
     {
+        if (loggingDisabled)
+            return;
+
         try
         {
 
@@ -417,6 +426,9 @@ public class PortalStatisticsImpl extend
      */
     public void logUserLogin(RequestContext request, long msElapsedLoginTime)
     {
+        if (loggingDisabled)
+            return;
+
         try
         {
             HttpServletRequest req = request.getRequest();



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message