Return-Path: Delivered-To: apmail-portals-jetspeed-dev-archive@www.apache.org Received: (qmail 90937 invoked from network); 4 May 2009 14:18:10 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 4 May 2009 14:18:10 -0000 Received: (qmail 6133 invoked by uid 500); 4 May 2009 14:18:10 -0000 Delivered-To: apmail-portals-jetspeed-dev-archive@portals.apache.org Received: (qmail 6089 invoked by uid 500); 4 May 2009 14:18:10 -0000 Mailing-List: contact jetspeed-dev-help@portals.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Jetspeed Developers List" Delivered-To: mailing list jetspeed-dev@portals.apache.org Received: (qmail 6079 invoked by uid 99); 4 May 2009 14:18:10 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2009 14:18:10 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2009 14:18:09 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 6183D23888A4; Mon, 4 May 2009 14:17:49 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r771313 - /portals/jetspeed-2/portal/trunk/components/jetspeed-registry/src/main/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java Date: Mon, 04 May 2009 14:17:49 -0000 To: jetspeed-dev@portals.apache.org From: woonsan@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090504141749.6183D23888A4@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: woonsan Date: Mon May 4 14:17:48 2009 New Revision: 771313 URL: http://svn.apache.org/viewvc?rev=771313&view=rev Log: JS2-946: Removing unmodifiable wrapper for language list from portlet definition. SVN history shows that this kind wrapping was done by r705396 when pluto-2 was initially integrated. However, I think it was accidental because there was no special reason to wrap it at that time and there's still a client code (PAM) in j2-admin depending on mutable list. (This broke PAM portlet, which needed a mutable language list to remove an item.) Modified: portals/jetspeed-2/portal/trunk/components/jetspeed-registry/src/main/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java Modified: portals/jetspeed-2/portal/trunk/components/jetspeed-registry/src/main/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java URL: http://svn.apache.org/viewvc/portals/jetspeed-2/portal/trunk/components/jetspeed-registry/src/main/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java?rev=771313&r1=771312&r2=771313&view=diff ============================================================================== --- portals/jetspeed-2/portal/trunk/components/jetspeed-registry/src/main/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java (original) +++ portals/jetspeed-2/portal/trunk/components/jetspeed-registry/src/main/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java Mon May 4 14:17:48 2009 @@ -215,7 +215,7 @@ { languages = new ArrayList(); } - return Collections.unmodifiableList(languages); + return languages; } public Language addLanguage(Locale locale) --------------------------------------------------------------------- To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org For additional commands, e-mail: jetspeed-dev-help@portals.apache.org