portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From woon...@apache.org
Subject svn commit: r771313 - /portals/jetspeed-2/portal/trunk/components/jetspeed-registry/src/main/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java
Date Mon, 04 May 2009 14:17:49 GMT
Author: woonsan
Date: Mon May  4 14:17:48 2009
New Revision: 771313

URL: http://svn.apache.org/viewvc?rev=771313&view=rev
Log:
JS2-946: Removing unmodifiable wrapper for language list from portlet definition.
SVN history shows that this kind wrapping was done by r705396 when pluto-2 was initially integrated.
However, I think it was accidental because there was no special reason to wrap it at that
time and there's still a client code (PAM) in j2-admin depending on mutable list. (This broke
PAM portlet, which needed a mutable language list to remove an item.)

Modified:
    portals/jetspeed-2/portal/trunk/components/jetspeed-registry/src/main/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java

Modified: portals/jetspeed-2/portal/trunk/components/jetspeed-registry/src/main/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java
URL: http://svn.apache.org/viewvc/portals/jetspeed-2/portal/trunk/components/jetspeed-registry/src/main/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java?rev=771313&r1=771312&r2=771313&view=diff
==============================================================================
--- portals/jetspeed-2/portal/trunk/components/jetspeed-registry/src/main/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java
(original)
+++ portals/jetspeed-2/portal/trunk/components/jetspeed-registry/src/main/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java
Mon May  4 14:17:48 2009
@@ -215,7 +215,7 @@
         {
             languages = new ArrayList<Language>();
         }
-        return Collections.unmodifiableList(languages);
+        return languages;
     }
     
     public Language addLanguage(Locale locale)



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message