portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Watler <wat...@wispertel.net>
Subject Re: Odd critera and API types in Security
Date Mon, 02 Feb 2009 18:36:20 GMT
Ate/Dennis,

WRT #2, yes, the JetspeedPermissionStoreManager API also has many direct 
references to PersistentJetspeedPermission which I am changing to 
JetspeedPermission as well.

Randy

Randy Watler wrote:
> Ate/Dennis,
>
> As you know, I am trolling through Security porting it over to JPA. I 
> noticed a few minor things in the process that you might be interested 
> in looking at:
>
> 1. In JetspeedSecurityPersistenceManager revoke[All]Permission() 
> methods, the 'domainId' criteria appear to be incorrect. Should these 
> really be criteria on 'principal.domainId'?
>
> 2. In the security API JetspeedPermissionAccessManager, there are two 
> methods specified with concrete class argument types instead of API 
> interfaces: getPermissions(PersistentJetspeedPrincipal principal) and 
> getPrincipals(PersistentJetspeedPermission permission, ...). I have 
> had to change these to JetspeedPrincipal and JetspeedPermission, 
> respectively, so that I can implement a JPA version of the access 
> manager. Please let me know if we need to implement 'persistence' 
> capable interfaces or if this was just an oversight.
>
> Thanks,
>
> Randy
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message