portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a..@apache.org
Subject svn commit: r687480 - in /portals/jetspeed-2/portal/branches/JS2-869/components/jetspeed-registry/src/main/java/org/apache/jetspeed: components/portletentity/PortletEntityImpl.java om/portlet/impl/PortletDefinitionImpl.java
Date Wed, 20 Aug 2008 21:48:58 GMT
Author: ate
Date: Wed Aug 20 14:48:58 2008
New Revision: 687480

URL: http://svn.apache.org/viewvc?rev=687480&view=rev
Log:
static references to Spring managed objects are very dangerous if the Spring context is reloaded,
like with the test cases, or (more important) reloading the Jetspeed webapp (future requirement)

Modified:
    portals/jetspeed-2/portal/branches/JS2-869/components/jetspeed-registry/src/main/java/org/apache/jetspeed/components/portletentity/PortletEntityImpl.java
    portals/jetspeed-2/portal/branches/JS2-869/components/jetspeed-registry/src/main/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java

Modified: portals/jetspeed-2/portal/branches/JS2-869/components/jetspeed-registry/src/main/java/org/apache/jetspeed/components/portletentity/PortletEntityImpl.java
URL: http://svn.apache.org/viewvc/portals/jetspeed-2/portal/branches/JS2-869/components/jetspeed-registry/src/main/java/org/apache/jetspeed/components/portletentity/PortletEntityImpl.java?rev=687480&r1=687479&r2=687480&view=diff
==============================================================================
--- portals/jetspeed-2/portal/branches/JS2-869/components/jetspeed-registry/src/main/java/org/apache/jetspeed/components/portletentity/PortletEntityImpl.java
(original)
+++ portals/jetspeed-2/portal/branches/JS2-869/components/jetspeed-registry/src/main/java/org/apache/jetspeed/components/portletentity/PortletEntityImpl.java
Wed Aug 20 14:48:58 2008
@@ -68,11 +68,11 @@
 {   
     private Long oid;
     private JetspeedObjectID id;
-    private static PortletPreferencesProvider portletPreferencesProvider;
-    private static PortletEntityAccessComponent portletEntityAccess;    
-    private static PortletRegistry registry;
-    private static RequestContextComponent requestContextComponent;
-    private static PageManager pageManager;
+    private PortletPreferencesProvider portletPreferencesProvider;
+    private PortletEntityAccessComponent portletEntityAccess;    
+    private PortletRegistry registry;
+    private RequestContextComponent requestContextComponent;
+    private PageManager pageManager;
     
     protected PreferenceSetComposite pagePreferenceSet;
     protected Map perPrincipalPrefs = new HashMap();

Modified: portals/jetspeed-2/portal/branches/JS2-869/components/jetspeed-registry/src/main/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java
URL: http://svn.apache.org/viewvc/portals/jetspeed-2/portal/branches/JS2-869/components/jetspeed-registry/src/main/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java?rev=687480&r1=687479&r2=687480&view=diff
==============================================================================
--- portals/jetspeed-2/portal/branches/JS2-869/components/jetspeed-registry/src/main/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java
(original)
+++ portals/jetspeed-2/portal/branches/JS2-869/components/jetspeed-registry/src/main/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java
Wed Aug 20 14:48:58 2008
@@ -84,9 +84,9 @@
  */
 public class PortletDefinitionImpl implements PortletDefinitionComposite, PreferencesValidatorFactory,
Serializable, Support
 {
-    private static PortletRegistry registry;
-    private static PortletFactory  portletFactory;
-    private static PortletPreferencesProvider portletPreferencesProvider;
+    private PortletRegistry registry;
+    private PortletFactory  portletFactory;
+    private PortletPreferencesProvider portletPreferencesProvider;
     
     private Long id;
     private JetspeedLongObjectID oid;



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message