Return-Path: 
 <jetspeed-dev-return-31516-apmail-portals-jetspeed-dev-archive=portals.apache.org@portals.apache.org>
Delivered-To: apmail-portals-jetspeed-dev-archive@www.apache.org
Received: (qmail 29199 invoked from network); 23 Dec 2007 16:22:46 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 23 Dec 2007 16:22:46 -0000
Received: (qmail 58529 invoked by uid 500); 23 Dec 2007 16:22:35 -0000
Delivered-To: apmail-portals-jetspeed-dev-archive@portals.apache.org
Received: (qmail 58515 invoked by uid 500); 23 Dec 2007 16:22:34 -0000
Mailing-List: contact jetspeed-dev-help@portals.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:jetspeed-dev-help@portals.apache.org>
List-Unsubscribe: <mailto:jetspeed-dev-unsubscribe@portals.apache.org>
List-Post: <mailto:jetspeed-dev@portals.apache.org>
List-Id: <jetspeed-dev.portals.apache.org>
Reply-To: "Jetspeed Developers List" <jetspeed-dev@portals.apache.org>
Delivered-To: mailing list jetspeed-dev@portals.apache.org
Received: (qmail 58504 invoked by uid 99); 23 Dec 2007 16:22:34 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Dec 2007 08:22:34 -0800
X-ASF-Spam-Status: No, hits=-100.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9)
    by apache.org (qpsmtpd/0.29) with SMTP; Sun, 23 Dec 2007 16:22:31 +0000
Received: (qmail 29174 invoked from network); 23 Dec 2007 16:22:22 -0000
Received: from localhost (HELO ?127.0.0.1?) (127.0.0.1)
  by localhost with SMTP; 23 Dec 2007 16:22:22 -0000
Message-ID: <476E8B3C.7030304@apache.org>
Date: Sun, 23 Dec 2007 17:22:20 +0100
From: Carsten Ziegeler <cziegeler@apache.org>
User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031)
MIME-Version: 1.0
To: Jetspeed Developers List <jetspeed-dev@portals.apache.org>
Subject: Re: [RT] Spring Configuation
References: <473DD2CF.8010501@apache.org>
 <059F1F6C0F6C8842B55E064DEB00138E077290BB@EXCHVS01.bcbsmamd.net>
 <4741CA6E.1010204@hippo.nl> <FB20B3B9-EA28-46A5-B27A-44FDC612B7F1@yahoo.com>
 <47438C44.9050201@douma.nu> <4748BED8.5060805@apache.org>
 <475D539B.1050304@apache.org> <475D7A70.3050901@douma.nu>
 <475E52F7.5050902@apache.org>
 <A32AEED1-E328-4512-A5F3-6EF2B17F0F65@yahoo.com> <476920F5.50301@apache.org>
 <476AE251.4070509@douma.nu>
In-Reply-To: <476AE251.4070509@douma.nu>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org

Ate Douma wrote:
> To be honest, I'm a bit confused about what you are proposing.
> Without a concrete example and explanation what this rule language
> is/looks like and is supposed to do my gut reaction is this might be
> overkill for what we need.
> I definitely think we need as simple as possible solution using
> conventions and a language commonly known.
> That's why I tried to come up with a jstl/el type of example as its a
> standard and widly known language and the runtime evaluation should be
> easily embeddable.
> Defining or even dynamically loading our own custom language seems a bit
> too far fetched.
> But maybe I simply misunderstood your proposal and is it actually very
> simple, so it would be great if you could provide an example.
> 
I haven't really thought that much about how the language should look
like. Now, the problem with your proposal is, that you want to embed the
languange inside a spring bean definition file - which is not possible
by just adding new elements with their own namespace. Of course, one
solution would be to pre-process each spring bean definition file, but
this would require that each and everyone uses a specific xml parser for
this (which does the filtering).

So, my proposal is to keep the conditions out of the spring bean
definition file, and create a simple rule file like (don't quote me on
the used element names, they should just give the idea):

<rules>
  <rule id="database">
    <when test="${pagemanagment='database'}">
      <include src="optional/db-pm.xml"/>
    </when>
    <otherwise>
      <include src="optional/castor-pm.xml"/>
    </otherwise>
  </rule>

  <rule id="wsrp">
    <if test="${wsrp.enabled}">
      <include src="optional/wsrp-beans.xml"/>
    </if>
  </rule>
</rules>

This is basically the equivalent of your proposal, with the difference
of using an extra file for the conditions and putting the various
conditional beans in separate files.

Carsten
-- 
Carsten Ziegeler
cziegeler@apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org