Return-Path: Delivered-To: apmail-portals-jetspeed-dev-archive@www.apache.org Received: (qmail 90167 invoked from network); 27 Nov 2007 09:55:34 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Nov 2007 09:55:34 -0000 Received: (qmail 58254 invoked by uid 500); 27 Nov 2007 09:55:22 -0000 Delivered-To: apmail-portals-jetspeed-dev-archive@portals.apache.org Received: (qmail 58230 invoked by uid 500); 27 Nov 2007 09:55:22 -0000 Mailing-List: contact jetspeed-dev-help@portals.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Jetspeed Developers List" Delivered-To: mailing list jetspeed-dev@portals.apache.org Received: (qmail 58219 invoked by uid 99); 27 Nov 2007 09:55:21 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Nov 2007 01:55:21 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Nov 2007 09:55:10 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 0EDD71A983A; Tue, 27 Nov 2007 01:55:13 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r598577 - /portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal-site/src/test/org/apache/jetspeed/portalsite/TestPortalSite.java Date: Tue, 27 Nov 2007 09:55:12 -0000 To: jetspeed-dev@portals.apache.org From: woonsan@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20071127095513.0EDD71A983A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: woonsan Date: Tue Nov 27 01:55:10 2007 New Revision: 598577 URL: http://svn.apache.org/viewvc?rev=598577&view=rev Log: Fixing a testcase: TestPortalSite always fails on a non-English system because it assumes that the default locale is English on the test machine. For example, `assertEquals("Back to", backMenu.getTitle());' always fails because backMenu.getTitle() is equivalent to backMenu.getTitle(Locale.getDefault()). (The default locale is ko_KR in my case.) There are too many codes assuming English locale, but keeping these as before seems better to read. Therefore, I added default locale setting code before testing for non-English testing environments. Modified: portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal-site/src/test/org/apache/jetspeed/portalsite/TestPortalSite.java Modified: portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal-site/src/test/org/apache/jetspeed/portalsite/TestPortalSite.java URL: http://svn.apache.org/viewvc/portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal-site/src/test/org/apache/jetspeed/portalsite/TestPortalSite.java?rev=598577&r1=598576&r2=598577&view=diff ============================================================================== --- portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal-site/src/test/org/apache/jetspeed/portalsite/TestPortalSite.java (original) +++ portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal-site/src/test/org/apache/jetspeed/portalsite/TestPortalSite.java Tue Nov 27 01:55:10 2007 @@ -57,6 +57,11 @@ * portalSite - PortalSite component */ private PortalSite portalSite; + + /** + * default locale + */ + private Locale defaultLocale; /* (non-Javadoc) * @see junit.framework.TestCase#setUp() @@ -66,6 +71,8 @@ super.setUp(); this.pageManager = (PageManager) ctx.getBean("pageManager"); this.portalSite = (PortalSite) ctx.getBean("portalSite"); + this.defaultLocale = Locale.getDefault(); + Locale.setDefault(Locale.ENGLISH); } /* (non-Javadoc) @@ -74,6 +81,7 @@ protected void tearDown() throws Exception { super.tearDown(); + Locale.setDefault(this.defaultLocale); } /** --------------------------------------------------------------------- To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org For additional commands, e-mail: jetspeed-dev-help@portals.apache.org