Return-Path: Delivered-To: apmail-portals-jetspeed-dev-archive@www.apache.org Received: (qmail 22814 invoked from network); 10 Oct 2007 17:38:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 10 Oct 2007 17:38:36 -0000 Received: (qmail 96304 invoked by uid 500); 10 Oct 2007 17:09:50 -0000 Delivered-To: apmail-portals-jetspeed-dev-archive@portals.apache.org Received: (qmail 96280 invoked by uid 500); 10 Oct 2007 17:09:50 -0000 Mailing-List: contact jetspeed-dev-help@portals.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Jetspeed Developers List" Delivered-To: mailing list jetspeed-dev@portals.apache.org Received: (qmail 96268 invoked by uid 99); 10 Oct 2007 17:09:50 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Oct 2007 10:09:50 -0700 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [69.147.64.88] (HELO smtp115.sbc.mail.sp1.yahoo.com) (69.147.64.88) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 10 Oct 2007 17:09:53 +0000 Received: (qmail 18834 invoked from network); 10 Oct 2007 17:08:32 -0000 Received: from unknown (HELO ?192.168.3.102?) (davidseantaylor2@sbcglobal.net@75.32.148.169 with plain) by smtp115.sbc.mail.sp1.yahoo.com with SMTP; 10 Oct 2007 17:08:31 -0000 X-YMail-OSG: PoKDQq0VM1mUi.oKgZQxA1SCVdIy2GtijF8U5HM3_9X49NP7 Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: <49336C35F4B12E4FA1B5D9B63B187C2D0526A111@USCIMPLM004.net.plm.eds.com> References: <13105025.post@talk.nabble.com> <260307300710081515p810f5ceued9ffaac21b9f09f@mail.gmail.com> <49336C35F4B12E4FA1B5D9B63B187C2D05269DDF@USCIMPLM004.net.plm.eds.com> <8e9185910710090732r2ea83dbdxa3695e971cee8ff8@mail.gmail.com> <845B9D7A-2756-4754-96EB-68B592068619@bluesunrise.com> <8e9185910710091122p5b46ae90y65f57255d05c8862@mail.gmail.com> <49336C35F4B12E4FA1B5D9B63B187C2D05269FE5@USCIMPLM004.net.plm.eds.com> <258A791E-4B7A-48C7-8F8B-9BF14C3F4FC8@bluesunrise.com> <49336C35F4B12E4FA1B5D9B63B187C2D0526A08C@USCIMPLM004.net.plm.eds.com> <49336C35F4B12E4FA1B5D9B63B187C2D0526A111@USCIMPLM004.net.plm.eds.com> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <2F84D79E-B63C-44D9-B09D-1E768F027C0F@bluesunrise.com> Content-Transfer-Encoding: 7bit From: David Sean Taylor Subject: Re: Caused by: java.lang.OutOfMemoryError: Java heap space Date: Wed, 10 Oct 2007 10:08:32 -0700 To: "Jetspeed Developers List" X-Mailer: Apple Mail (2.752.3) X-Virus-Checked: Checked by ClamAV on apache.org On Oct 9, 2007, at 1:44 PM, Weaver, Scott wrote: > Slight issue. > > org.apache.jetspeed.container.window.PortletWindowAccessor.getPortletW > in > dows() returns a Set of HashMap.Entrys. Since this is moving to > cache, > there will no longer be a HashMap to call getEntrySet() on. I propose > just changing this to return a Set of PortletWindows. The only code > that will need to change within Jetspeed is the > org.apache.jetspeed.aggregator.impl.PortletTrackingManagerImpl. It > has > three methods that call the getPortletWindows(). The three methods > can > easily be modified to expect a Set of PortletWindows as opposed to > a Set > of HashMap.Entrys. > > Does anyone have an issue with me changing this behavior? > no i don't have issue I think it would be better to return a set of portlet window The API was never properly documented, could you specify in the javadoc what kind of elements are in the set --------------------------------------------------------------------- To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org For additional commands, e-mail: jetspeed-dev-help@portals.apache.org