Mailing-List: contact jetspeed-dev-help@portals.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jetspeed Developers List" <jetspeed-dev@portals.apache.org>
Message-ID: <17793197.1193616050618.JavaMail.jira@brutus>
Date: Sun, 28 Oct 2007 17:00:50 -0700 (PDT)
From: "Ate Douma (JIRA)" <jetspeed-dev@portals.apache.org>
To: jetspeed-dev@portals.apache.org
Subject: [jira] Closed: (JS2-787) Non-informative error handling in
 PortalSiteManager. I've created a patch
In-Reply-To: <26270246.1192028330848.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/JS2-787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ate Douma closed JS2-787.
-------------------------

       Resolution: Fixed
    Fix Version/s: 2.2
                   2.1.3

Vitaly,

Your patch format was invalid. Don't know how you created it, but Eclipse could apply it.
Anyway, I've committed a slight different solution as you proposed: by logging the exception instead.


> Non-informative error handling in PortalSiteManager. I've created a patch
> -------------------------------------------------------------------------
>
>                 Key: JS2-787
>                 URL: https://issues.apache.org/jira/browse/JS2-787
>             Project: Jetspeed 2
>          Issue Type: Improvement
>          Components: Admin Portlets
>    Affects Versions: 2.1.3
>            Reporter: Vitaly Baranovsky
>            Assignee: Ate Douma
>             Fix For: 2.1.3, 2.2
>
>         Attachments: patch.txt
>
>
> I think, it is a bad practice don't writing e.getMessage() when writing to log.
> Now Portal Site Manager writes "Failed to get root folder", but I don't know why...
> I've created a patch to log more informative messages.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org