portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From woon...@apache.org
Subject svn commit: r570080 - /portals/jetspeed-2/trunk/components/jetspeed-portal/src/main/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java
Date Mon, 27 Aug 2007 11:34:27 GMT
Author: woonsan
Date: Mon Aug 27 04:34:26 2007
New Revision: 570080

URL: http://svn.apache.org/viewvc?rev=570080&view=rev
Log:
During high load testings, I found that an NPE occurred in the constructor of ServletRequestImpl.
The constructor tries to initialize the static members: mergePortalParametersWithPortletParameters,
mergePortalParametersBeforePortletParameters. However it checks only if the first static member
is null. This causes an NPE on the second static member in a very high load testing environment.
So, checking should be separated for each static member.

Modified:
    portals/jetspeed-2/trunk/components/jetspeed-portal/src/main/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java

Modified: portals/jetspeed-2/trunk/components/jetspeed-portal/src/main/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java
URL: http://svn.apache.org/viewvc/portals/jetspeed-2/trunk/components/jetspeed-portal/src/main/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java?rev=570080&r1=570079&r2=570080&view=diff
==============================================================================
--- portals/jetspeed-2/trunk/components/jetspeed-portal/src/main/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java
(original)
+++ portals/jetspeed-2/trunk/components/jetspeed-portal/src/main/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java
Mon Aug 27 04:34:26 2007
@@ -136,6 +136,10 @@
         {
             mergePortalParametersWithPortletParameters = 
                 new Boolean(Jetspeed.getContext().getConfiguration().getBoolean("merge.portal.parameters.with.portlet.parameters",
false));
+        }
+        
+        if (mergePortalParametersBeforePortletParameters == null)
+        {
             mergePortalParametersBeforePortletParameters = 
                 new Boolean(Jetspeed.getContext().getConfiguration().getBoolean("merge.portal.parameters.before.portlet.parameters",
false));
         }



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message