Return-Path: Delivered-To: apmail-portals-jetspeed-dev-archive@www.apache.org Received: (qmail 63342 invoked from network); 29 Jun 2007 12:04:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 29 Jun 2007 12:04:16 -0000 Received: (qmail 43596 invoked by uid 500); 29 Jun 2007 12:04:18 -0000 Delivered-To: apmail-portals-jetspeed-dev-archive@portals.apache.org Received: (qmail 43565 invoked by uid 500); 29 Jun 2007 12:04:18 -0000 Mailing-List: contact jetspeed-dev-help@portals.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Jetspeed Developers List" Delivered-To: mailing list jetspeed-dev@portals.apache.org Received: (qmail 43554 invoked by uid 99); 29 Jun 2007 12:04:18 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jun 2007 05:04:18 -0700 X-ASF-Spam-Status: No, hits=-99.5 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jun 2007 05:04:14 -0700 Received: by eris.apache.org (Postfix, from userid 65534) id 81C211A981C; Fri, 29 Jun 2007 05:03:54 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r551863 - /portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/container/state/impl/JetspeedNavigationalStateCodec.java Date: Fri, 29 Jun 2007 12:03:54 -0000 To: jetspeed-dev@portals.apache.org From: ate@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20070629120354.81C211A981C@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: ate Date: Fri Jun 29 05:03:53 2007 New Revision: 551863 URL: http://svn.apache.org/viewvc?view=rev&rev=551863 Log: JS2-739: Improve Algorithms for Resource Validation and Template Localization - replace expensive StringUtils.replace(...) with more optimal inline code see: https://issues.apache.org/jira/browse/JS2-739 Modified: portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/container/state/impl/JetspeedNavigationalStateCodec.java Modified: portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/container/state/impl/JetspeedNavigationalStateCodec.java URL: http://svn.apache.org/viewvc/portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/container/state/impl/JetspeedNavigationalStateCodec.java?view=diff&rev=551863&r1=551862&r2=551863 ============================================================================== --- portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/container/state/impl/JetspeedNavigationalStateCodec.java (original) +++ portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/container/state/impl/JetspeedNavigationalStateCodec.java Fri Jun 29 05:03:53 2007 @@ -25,7 +25,6 @@ import javax.portlet.WindowState; import org.apache.commons.codec.binary.Base64; -import org.apache.commons.lang.StringUtils; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.apache.jetspeed.JetspeedActions; @@ -554,8 +553,7 @@ protected String decodeParameters(String value, String characterEncoding) throws UnsupportedEncodingException { - value = StringUtils.replace(value,"-","/"); - value = StringUtils.replace(value,"_","="); + value = value.replace('-','/').replace('_','='); if ( characterEncoding != null ) { return new String(Base64.decodeBase64(value.getBytes(characterEncoding)), characterEncoding); @@ -587,9 +585,7 @@ { value = new String(Base64.encodeBase64(value.getBytes())); } - value = StringUtils.replace(value,"/","-"); - value = StringUtils.replace(value,"=","_"); - return value; + return value.replace('/','-').replace('=','_'); } protected String encodeArgument( String argument, char escape ) --------------------------------------------------------------------- To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org For additional commands, e-mail: jetspeed-dev-help@portals.apache.org