portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ate Douma (JIRA)" <jetspeed-...@portals.apache.org>
Subject [jira] Resolved: (JS2-605) Query string parameters should not (by default) be provided to portlets to be compliant to JSR 168 spec requirements
Date Wed, 21 Feb 2007 02:50:05 GMT

     [ https://issues.apache.org/jira/browse/JS2-605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ate Douma resolved JS2-605.
---------------------------

    Resolution: Fixed

Implemented as described.

The now default and JSR-168 compliant behavior can be modified in jetspeed.properties:

# Until version 2.1, Jetspeed merged portal request parameters with portlet specific
# parameters, effectively allowing "shared" parameters.
# This is not compliant with the JSR-168 PLT.11, so by default this is now disabled.
#
# By setting merge.portal.parameters.with.portlet.parameters=true this feature can
# be "restored".
# In the situation of portal and portlet parameters with the same name, by default
# the portlet parameters will be provided first in the values array, but this too
# can be overridden by setting merge.portal.parameters.before.portlet.parameters=true
#
# Setting both these properties to true will deliver the "old" pre-2.1 behavior.
#----------------------------------------------------------------------------------
merge.portal.parameters.with.portlet.parameters=false
merge.portal.parameters.before.portlet.parameters=false
 

> Query string parameters should not (by default) be provided to portlets to be compliant
to JSR 168 spec requirements
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: JS2-605
>                 URL: https://issues.apache.org/jira/browse/JS2-605
>             Project: Jetspeed 2
>          Issue Type: Bug
>          Components: Container
>    Affects Versions: 2.1-dev
>            Reporter: Ate Douma
>         Assigned To: Ate Douma
>            Priority: Minor
>             Fix For: 2.1, 2.1-dev
>
>
> Jetspeed currently provides query string parameters to all portlets on the page requested.
> When a portlet already has a request parameter with the same name, the values are provided
as an array where the query string parameters take precedence.
> Example: with a query string parameter color=red and portlet parameter color=blue, the
portlet will receive color=[red,blue].
> Although the JSR 168 specs (PLT.11) doesn't make it very explicit this shouldn't be allowed
(and the TCK definitely doesn't validate it),
> the portlet 1.0 API javadoc for PortletRequest.getParameter(String) *is* explicit on
this: "Only parameters targeted to the current portlet are accessible."
> But, existing installations of Jetspeed-2 might already depend on this "feature".
> I won't simply "fix" this by making Jetspeed-2 strict to the specs, but instead make
this feature optional/configurable although by default it should be specs compliant.
> The solution will allow for three possible usages:
> a) strict - no query string parameters will be visible to portlets (default)
> b) portlet scoped parameters take precedence (like color=[blue,red] from the example
above)
> c) query string parameters take precedence (like color=[red,blue] from the example above
which is the current implementation)
>     

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message