portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a..@apache.org
Subject svn commit: r396816 - in /portals/jetspeed-2/trunk: jetspeed-api/src/java/org/apache/jetspeed/page/PageManager.java layout-portlets/src/java/org/apache/jetspeed/portlets/layout/MultiColumnPortlet.java
Date Tue, 25 Apr 2006 08:54:42 GMT
Author: ate
Date: Tue Apr 25 01:54:40 2006
New Revision: 396816

URL: http://svn.apache.org/viewcvs?rev=396816&view=rev
Log:
Fixing a PageNotFoundException thrown by the DatabasePageManager if you try to remove a portlet
from a page.
PageManager.getPage(String) expects a Page path parameter, not its id as described in the
api Javadoc!!!
CastorXmlPageManager didn't expose this bug as for a file based PSML page id and path are
always the same AFAIK.

Modified:
    portals/jetspeed-2/trunk/jetspeed-api/src/java/org/apache/jetspeed/page/PageManager.java
    portals/jetspeed-2/trunk/layout-portlets/src/java/org/apache/jetspeed/portlets/layout/MultiColumnPortlet.java

Modified: portals/jetspeed-2/trunk/jetspeed-api/src/java/org/apache/jetspeed/page/PageManager.java
URL: http://svn.apache.org/viewcvs/portals/jetspeed-2/trunk/jetspeed-api/src/java/org/apache/jetspeed/page/PageManager.java?rev=396816&r1=396815&r2=396816&view=diff
==============================================================================
--- portals/jetspeed-2/trunk/jetspeed-api/src/java/org/apache/jetspeed/page/PageManager.java
(original)
+++ portals/jetspeed-2/trunk/jetspeed-api/src/java/org/apache/jetspeed/page/PageManager.java
Tue Apr 25 01:54:40 2006
@@ -245,13 +245,13 @@
      * getPage
      * </p>
      *
-     * Returns a PSML document for the given key
+     * Returns a Page based on its path
      *
-     * @param locator The locator descriptor of the document to be retrieved.
+     * @param path
      * @throws PageNotFoundException if the page cannot be found
      * @throws NodeException
      */
-    public Page getPage(String id) throws PageNotFoundException, NodeException;
+    public Page getPage(String path) throws PageNotFoundException, NodeException;
     
     /**
      * <p>

Modified: portals/jetspeed-2/trunk/layout-portlets/src/java/org/apache/jetspeed/portlets/layout/MultiColumnPortlet.java
URL: http://svn.apache.org/viewcvs/portals/jetspeed-2/trunk/layout-portlets/src/java/org/apache/jetspeed/portlets/layout/MultiColumnPortlet.java?rev=396816&r1=396815&r2=396816&view=diff
==============================================================================
--- portals/jetspeed-2/trunk/layout-portlets/src/java/org/apache/jetspeed/portlets/layout/MultiColumnPortlet.java
(original)
+++ portals/jetspeed-2/trunk/layout-portlets/src/java/org/apache/jetspeed/portlets/layout/MultiColumnPortlet.java
Tue Apr 25 01:54:40 2006
@@ -382,7 +382,7 @@
                     {
                         // TODO: for now retrieve the real Page instead of ContentPage
                         //       because removing fragments isn't working through the ContentFragment
wrapping
-                        page = pageManager.getPage(requestPage.getId());
+                        page = pageManager.getPage(requestPage.getPath());
                     }
                     catch (Exception e)
                     {



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message