portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Le Strat <dlest...@yahoo.com>
Subject Re: svn commit: r349078 - /portals/jetspeed-2/trunk/components/prefs/src/java/org/apache/jetspeed/prefs/impl/PersistenceBrokerPreferencesProvider.java
Date Sat, 26 Nov 2005 21:23:25 GMT
David,

I have completed the changes we discussed. I ran all
the tests and they all passed successfully.  Do we
have a test covering the scenario you mention below?
Let me know.

For more information on the changes made, see:

http://issues.apache.org/jira/browse/JS2-431

The database schema has been changed as a result of
this issue.

Regards,

David Le Strat

--- taylor@apache.org wrote:

> Author: taylor
> Date: Fri Nov 25 21:08:02 2005
> New Revision: 349078
> 
> URL:
> http://svn.apache.org/viewcvs?rev=349078&view=rev
> Log:
> might need to revive the SQL query, just putting in
> a reminder here
> 
> It appears that the User Manager does NOT update the
> PREFS_NODE_PROPERTY_KEY table 
> Actually, its the preference impl that fails, which
> User Manager calls
> This has broken the lookupPreference call on the
> PersistenceBrokerPreferencesProvider, which uses 
> OJB to do the lookup, and the OJB mapping REQUIRES
> using the PREFS_NODE_PROPERTY_KEY table in the
> lookup
> even though the prefs API does not write to the
> PREFS_NODE_PROPERTY_KEY table
> Thus...I am NOT finding user info attributes stored
> by the prefs api (and the user manager)
> 
> DLS: could you please review this.
> Im really not sure what the PREFS_NODE_PROPERTY_KEY
> is used for, but currently its very broken
> 
> Modified:
>    
>
portals/jetspeed-2/trunk/components/prefs/src/java/org/apache/jetspeed/prefs/impl/PersistenceBrokerPreferencesProvider.java
> 
> Modified:
>
portals/jetspeed-2/trunk/components/prefs/src/java/org/apache/jetspeed/prefs/impl/PersistenceBrokerPreferencesProvider.java
> URL:
>
http://svn.apache.org/viewcvs/portals/jetspeed-2/trunk/components/prefs/src/java/org/apache/jetspeed/prefs/impl/PersistenceBrokerPreferencesProvider.java?rev=349078&r1=349077&r2=349078&view=diff
>
==============================================================================
> ---
>
portals/jetspeed-2/trunk/components/prefs/src/java/org/apache/jetspeed/prefs/impl/PersistenceBrokerPreferencesProvider.java
> (original)
> +++
>
portals/jetspeed-2/trunk/components/prefs/src/java/org/apache/jetspeed/prefs/impl/PersistenceBrokerPreferencesProvider.java
> Fri Nov 25 21:08:02 2005
> @@ -344,7 +344,8 @@
>  //            "FROM `prefs_node` p,
> prefs_property_key k, prefs_property_value v " +
>  //            "WHERE p.NODE_NAME = 'userinfo' and
> v.node_id = p.node_id " + 
>  //            "AND v.property_key_id =
> k.property_key_id " +
> -//            "AND k.property_name = '";
> +//            "AND k.property_name = ? " +
> +//            "AND v.text_value = ?"    
>  
>          Criteria c = new Criteria();
>          if (nodeName != null)
> 
> 
> 
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> jetspeed-dev-unsubscribe@portals.apache.org
> For additional commands, e-mail:
> jetspeed-dev-help@portals.apache.org
> 
> 


________________________
David Le Strat
Blogging @ http://dlsthoughts.blogspot.com


	
		
__________________________________ 
Yahoo! Mail - PC Magazine Editors' Choice 2005 
http://mail.yahoo.com

---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message