portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a..@apache.org
Subject svn commit: r332191 - /portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/util/descriptor/PortletPreferenceRule.java
Date Thu, 10 Nov 2005 01:34:25 GMT
Author: ate
Date: Wed Nov  9 17:34:22 2005
New Revision: 332191

URL: http://svn.apache.org/viewcvs?rev=332191&view=rev
Log:
Fix for digesting PortletPreferences.
The digester rule didn't reset the readOnly property before processing a new definition.
This caused non-readonly preferences to be stored as readonly after a readonly preference
was digested before!

Modified:
    portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/util/descriptor/PortletPreferenceRule.java

Modified: portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/util/descriptor/PortletPreferenceRule.java
URL: http://svn.apache.org/viewcvs/portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/util/descriptor/PortletPreferenceRule.java?rev=332191&r1=332190&r2=332191&view=diff
==============================================================================
--- portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/util/descriptor/PortletPreferenceRule.java
(original)
+++ portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/util/descriptor/PortletPreferenceRule.java
Wed Nov  9 17:34:22 2005
@@ -54,7 +54,10 @@
         portlet = (PortletDefinitionComposite) peeked;
         portlet.setPortletApplicationDefinition((PortletApplicationDefinition) digester.getRoot());
         
-        values = new ArrayList();
+        // reset properties to default values
+        // as the same instance of this rule can be used multiple times
+        values = new ArrayList();        
+        readOnly = false;
         
         TempValueObject temp = new TempValueObject();
         digester.push(temp);



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message