Return-Path: Delivered-To: apmail-portals-jetspeed-dev-archive@www.apache.org Received: (qmail 90668 invoked from network); 1 Jul 2005 17:41:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 1 Jul 2005 17:41:21 -0000 Received: (qmail 63732 invoked by uid 500); 1 Jul 2005 17:41:18 -0000 Delivered-To: apmail-portals-jetspeed-dev-archive@portals.apache.org Received: (qmail 63713 invoked by uid 500); 1 Jul 2005 17:41:17 -0000 Mailing-List: contact jetspeed-dev-help@portals.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Jetspeed Developers List" Delivered-To: mailing list jetspeed-dev@portals.apache.org Received: (qmail 63700 invoked by uid 99); 1 Jul 2005 17:41:17 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jul 2005 10:41:17 -0700 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=WEIRD_QUOTING X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [216.23.125.30] (HELO mx.scriptall.com) (216.23.125.30) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jul 2005 10:41:19 -0700 Received: (qmail 24153 invoked by uid 512); 1 Jul 2005 13:41:24 -0400 Received: from david@bluesunrise.com by edison by uid 509 with qmail-scanner-1.22-st-qms (clamdscan: 0.75. spamassassin: 2.63. Clear:RC:1(64.105.95.98):. Processed in 0.02964 secs); 01 Jul 2005 17:41:24 -0000 X-Antivirus-MYDOMAIN-Mail-From: david@bluesunrise.com via edison X-Antivirus-MYDOMAIN: 1.22-st-qms (Clear:RC:1(64.105.95.98):. Processed in 0.02964 secs Process 24149) Received: from h-64-105-95-98.snvacaid.covad.net (HELO [192.168.1.22]) (david@bluesunrise.com@64.105.95.98) by mx.scriptall.com with SMTP; Fri, 01 Jul 2005 13:41:23 -0400 Message-ID: <42C58036.3050908@bluesunrise.com> Date: Fri, 01 Jul 2005 10:41:10 -0700 From: David Sean Taylor User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jetspeed Developers List Subject: Re: svn commit: r202133 - in /portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed: services/title/DynamicTitleServiceImpl.java velocity/JetspeedPowerToolImpl.java References: <20050628054013.73803.qmail@minotaur.apache.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N James Liao wrote: > Hi all, > I think the optimize for DynamicTitleServiceImpl have a problem. > If a portlet's Resources doesn't contain javax.portlet.title property, > the portlet will lost its title. For example, almost all the > Administrative portlet have this problem. > > I have do a little bit investigated on it. I found the cause of this > is in LanguageImpl and LanguageSetImpl. The LanguageImpl's method: > setTitle(), setShortTitle() and setKeywords() will not set the value > into DefaultsResourceBundle object's defaultValues Map. > > So can not use the LanguageSetImpl's createLanguage method like this: > > createLanguage(lang.getLocale(), loadResourceBundle(lang.getLocale()),"","",""); > language.setTitle(lang.getTitle()); > language.setShortTitle(lang.getShortTitle()); > language.setKeywords(StringUtils.join(lang.getKeywords(), ",")); > > Should be used like this: > createLanguage(lang.getLocale(), loadResourceBundle(lang.getLocale()), > lang.getTitle(), lang.getShortTitle(), > StringUtils.join(lang.getKeywords(), ",")); > > If it is necessary, I could raise a bug for this and provide a patch. > Thanks (again) James I'll apply this patch and see how it works here today Regards, -- David Sean Taylor Bluesunrise Software david@bluesunrise.com [office] +01 707 773-4646 [mobile] +01 707 529 9194 --------------------------------------------------------------------- To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org For additional commands, e-mail: jetspeed-dev-help@portals.apache.org