Mailing-List: contact jetspeed-dev-help@portals.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jetspeed Developers List" <jetspeed-dev@portals.apache.org>
Received-SPF: pass (asf.osuosl.org: local policy)
Message-ID: <42C186BE.2060806@douma.nu>
Date: Tue, 28 Jun 2005 19:19:58 +0200
From: Ate Douma <ate@douma.nu>
User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)
MIME-Version: 1.0
To: Jetspeed Developers List <jetspeed-dev@portals.apache.org>
Subject: Re: svn commit: r202098 - in
 /portals/jetspeed-2/trunk/portal/src/java/org/apache/jetspeed:
 pipeline/valve/PageProfilerValve.java profiler/impl/ProfilerValveImpl.java
References: <20050627232529.34730.qmail@minotaur.apache.org>
	 <bad8571e05062802111518c087@mail.gmail.com>
	 <42C161A4.9080209@bluesunrise.com>
 <bad8571e05062809266756c783@mail.gmail.com>
In-Reply-To: <bad8571e05062809266756c783@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

James,

You are correct: the anonymous session is reused when you login properly.
And its actually something you usually want (consider a session based shopping cart).

There is a better solution than your workaround though and I will look into it this
evening or tomorrow morning.

Regards, Ate

James Liao wrote:
> Hi David,
> I test it again thoroghly. But the problem still exist. It seems that
> the problem is cause by the following reason:
> 1. Each time the JetspeedRequestContext try to get something from
> session, it will call HttpServletRequest.getSession(), so there is a
> session for guest user.
> 
> 2. When you try to login to portal, LoginServlet will call 
> "HttpSession session = request.getSession(true);" This does not make
> sure to create a new session for this login action. The following is
> the Java Doc for this method:
> 
> Returns the current HttpSession  associated with this request or, if
> if there is no current session and create is true, returns a new
> session.
> 
> So it is the same session for the guest and user(admin, manager or
> someone else).
> 
> I think we could fix this problem by call
> "session.removeAttribute(PageProfilerValve.PROFILE_LOCATORS_PER_PRINCIPAL);"
> after "HttpSession session = request.getSession(true);" in
> LoginServlet.java. It will clear this attribute.
> 
> My entironment:
> JDK 1.4.2_07
> WinXP SP2
> 
> -James Liao
> 
> On 6/28/05, David Sean Taylor <david@bluesunrise.com> wrote:
> 
>>James Liao wrote:
>>
>>>Hi david,
>>>I have update to the latest J2, I found a problem about your optimize
>>>for ProfilerValve.
>>>
>>>For the first time, I visit J2 portal, I got a guest principal as
>>>default, you will getProfileLocators for guest principal and store
>>>into session.
>>>
>>>When I login as admin, the session is still the same session for
>>>previous guest, so it will not recreate the locators, still use the
>>>old locators for guest. I can't go anywhere except the
>>>default-page.psml. I think it is wrong.
>>>
>>
>>Well, IMO logging on should create a new session.
>>
>>--
>>David Sean Taylor
>>Bluesunrise Software
>>david@bluesunrise.com
>>[office] +01 707 773-4646
>>[mobile] +01 707 529 9194
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
>>For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
>>
>>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
> 
> 
> 
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org