portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject [jira] Updated: (JS2-5) portlet render called twice after an actionRequest
Date Fri, 02 Apr 2004 10:00:44 GMT
The following issue has been updated:

    Updater: Ate Douma (mailto:ate@douma.nu)
       Date: Fri, 2 Apr 2004 1:59 AM
    Comment:
I've traced the problem down to o.a.j.pipeline.valve.impl.ActionValveImpl.
Because Pluto will redirect the client after PortletAction processing there is no use in proceding
the pipeline after that.
The ActionValveImpl doesn't account for that and just invokes the next pipeline valve.

I created a simple workaround (patch attached) which checks after PortletAction processing
if the response has been committed. According to the specs nothing should be written to the
response (except for an allowed redirect) so if the response has been committed it may be
assumed that a client redirect has been send.

I'm not sure if this covers all possible situations but with the current Pluto implementation
this does solve the problem.

    Changes:
             Attachment changed to JS2-5-patch.txt
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://issues.apache.org/jira/browse/JS2-5?page=history

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/JS2-5

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JS2-5
    Summary: portlet render called twice after an actionRequest
       Type: Bug

     Status: Unassigned
   Priority: Major

    Project: Jetspeed 2
   Versions:
             2.0-dev/cvs

   Assignee: 
   Reporter: Ate Douma

    Created: Thu, 1 Apr 2004 12:27 PM
    Updated: Fri, 2 Apr 2004 1:59 AM
Environment: WindowsXP, J2SE1.4.2_03, Tomcat 4.1.29

Description:
I just noticed that a portlet render method is called twice as result of an ActionRequest.

Furthermore, the RenderRequest contains all the ActionRequest parameters as well (which is
a violation of the specs).

Debugging isn't so easy as the render events happen in seperate o.a.j.aggregator.impl.Worker
threads.



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org


Mime
View raw message