Return-Path: Delivered-To: apmail-jakarta-jetspeed-dev-archive@apache.org Received: (qmail 61947 invoked from network); 2 Jan 2002 12:45:11 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 2 Jan 2002 12:45:11 -0000 Received: (qmail 21156 invoked by uid 97); 2 Jan 2002 12:45:09 -0000 Delivered-To: qmlist-jakarta-archive-jetspeed-dev@jakarta.apache.org Received: (qmail 21135 invoked by uid 97); 2 Jan 2002 12:45:08 -0000 Mailing-List: contact jetspeed-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jetspeed Developers List" Reply-To: "Jetspeed Developers List" Delivered-To: mailing list jetspeed-dev@jakarta.apache.org Received: (qmail 21124 invoked by uid 50); 2 Jan 2002 12:45:08 -0000 Date: 2 Jan 2002 12:45:08 -0000 Message-ID: <20020102124508.21123.qmail@nagoya.betaversion.org> From: bugzilla@apache.org To: jetspeed-dev@jakarta.apache.org Cc: Subject: DO NOT REPLY [Bug 5604] - Clicking maximise on a portlet should be "sticky" X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5604 Clicking maximise on a portlet should be "sticky" ------- Additional Comments From kimptoc_mail@yahoo.com 2002-01-02 04:45 ------- The change that I plan to commit is as follows: If "Maximize" action is pressed, save the portlet name into the users temp storage (ie it only lasts as long as they are logged in at most). In "Restore", remove this temporary setting. In "JetspeedSessionValidator", check for this temp storage entry, if present, set the ScreenTemplate to the "Maximise". Comments - I will commit this later today/early tomorrow, unless significant changes are identified. Here is the proposed diff, for your info: Index: src/java/org/apache/jetspeed/modules/actions/JetspeedSessionValidator.java =================================================================== RCS file: /home/cvs/jakarta- jetspeed/src/java/org/apache/jetspeed/modules/actions/JetspeedSessionValidator.j ava,v retrieving revision 1.10 diff -r1.10 JetspeedSessionValidator.java 123a124,130 > > String maximizedPortlet = (String)jdata.getUser().getTemp("portlet"); > if (maximizedPortlet != null) { > jdata.setPortlet(maximizedPortlet); > jdata.setScreenTemplate("Maximize"); > } > 126c133,136 < jdata.setPortlet(jdata.getParameters().getString("portlet")); --- > String paramPortlet = jdata.getParameters().getString("portlet"); > if (paramPortlet != null && paramPortlet.length() > 0) { > jdata.setPortlet(paramPortlet); > } Index: src/java/org/apache/jetspeed/modules/actions/controls/Maximize.java =================================================================== RCS file: /home/cvs/jakarta- jetspeed/src/java/org/apache/jetspeed/modules/actions/controls/Maximize.java,v retrieving revision 1.5 diff -r1.5 Maximize.java 59a60 > import org.apache.turbine.util.Log; 90a92,94 > > //record that this portlet is now maximized > jdata.getUser().setTemp("portlet",name); Index: src/java/org/apache/jetspeed/modules/actions/controls/Restore.java =================================================================== RCS file: /home/cvs/jakarta- jetspeed/src/java/org/apache/jetspeed/modules/actions/controls/Restore.java,v retrieving revision 1.7 diff -r1.7 Restore.java 84c84,85 < String name = ((JetspeedRunData)rundata).getPortlet(); --- > JetspeedRunData jdata = (JetspeedRunData)rundata; > String name = jdata.getPortlet(); 106c107 < while (((JetspeedRunData)rundata).getCustomized()!=null) --- > while (jdata.getCustomized()!=null) 108c109 < ((JetspeedRunData)rundata).setCustomized(null); --- > jdata.setCustomized(null); 110c111,115 < rundata.setScreenTemplate(null); --- > > //remove the maximized portlet name - nothing is maximized now > rundata.getUser().removeTemp("portlet"); > > jdata.setScreenTemplate("Home"); -- To unsubscribe, e-mail: For additional commands, e-mail: