portals-bridges-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Sean Taylor (JIRA)" <bridges-...@portals.apache.org>
Subject [jira] Commented: (PB-79) defaultCustomPage is not initialized in FacesPortlet
Date Fri, 04 Jul 2008 17:03:43 GMT

    [ https://issues.apache.org/jira/browse/PB-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610625#action_12610625

David Sean Taylor commented on PB-79:

A committed a fix. Made the base class data members protected and removed the derived declarations:


Please let me know if this works for you

> defaultCustomPage is not initialized in FacesPortlet
> ----------------------------------------------------
>                 Key: PB-79
>                 URL: https://issues.apache.org/jira/browse/PB-79
>             Project: Portals Bridges
>          Issue Type: Bug
>          Components: jsf
>    Affects Versions: 1.0.4
>         Environment: Linux Fedora Core 4, Jetspeed 2.1.3 bundled demo download (Apache
Tomcat 5.5.23)
>            Reporter: Serkan Camurcuoglu
>            Assignee: David Sean Taylor
>            Priority: Minor
>   Original Estimate: 72h
>  Remaining Estimate: 72h
> FacesPortlet extends GenericServletPortlet, but it declares the defaultActionPage, defaultCustomPage,
defaultEditPage, defaultHelpPage and defaultViewPage fields again, therefore these fields
hide the fields in GenericServletPortlet. In the constructor of FacesPortlet, only defaultEditPage,
defaultViewPage and defaultHelpPage are initialized, the defaultActionPage and defaultCustomPage
fields are not initialized, and they are set to defaultViewPage since they are null. In fact,
the superclass initializes all these fields, but since the fields are duplicated, this has
no effect.
> Therefore, the user cannot set the value of defaultCustomPage using portlet.xml. I found
a workaround for this problem (by extending FacesPortlet and calling super.init() twice first
with a different mock PortletConfig and then the real PortletConfig), but this is not a good
and sustainable solution. Note that the same problem also exists for the defaultActionPage.
I believe that these fields should not be duplicated in FacesPortlet since GenericServletPortlet
provides public setters and getters for all these fields.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org

View raw message