ponymail-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [1/2] incubator-ponymail git commit: revert this, consensus is to leave as is.
Date Sat, 02 Sep 2017 23:57:42 GMT
On 29 August 2017 at 09:56,  <humbedooh@apache.org> wrote:
> Repository: incubator-ponymail
> Updated Branches:
>   refs/heads/master f85146df5 -> c8f4d3b7d
>
>
> revert this, consensus is to leave as is.

Which commit is this intended to revert?

It looks wrong to me.

> as redundant generator wasn't in 0.9, I'm leaving that one fixed.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/incubator-ponymail/repo
> Commit: http://git-wip-us.apache.org/repos/asf/incubator-ponymail/commit/4c87cd62
> Tree: http://git-wip-us.apache.org/repos/asf/incubator-ponymail/tree/4c87cd62
> Diff: http://git-wip-us.apache.org/repos/asf/incubator-ponymail/diff/4c87cd62
>
> Branch: refs/heads/master
> Commit: 4c87cd6286f5c4143898952dccdc6845d0d5ed6e
> Parents: afb891e
> Author: Daniel Gruno <humbedooh@apache.org>
> Authored: Tue Aug 29 10:52:54 2017 +0200
> Committer: Daniel Gruno <humbedooh@apache.org>
> Committed: Tue Aug 29 10:52:54 2017 +0200
>
> ----------------------------------------------------------------------
>  tools/generators.py | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/incubator-ponymail/blob/4c87cd62/tools/generators.py
> ----------------------------------------------------------------------
> diff --git a/tools/generators.py b/tools/generators.py
> index d8c373d..e320a06 100644
> --- a/tools/generators.py
> +++ b/tools/generators.py
> @@ -61,11 +61,7 @@ def medium(msg, body, lid, attachments):
>      # Use List ID
>      xbody += bytes(lid, encoding='ascii')
>      # Use Date header
> -    mdate = None
> -    try:
> -        mdate = email.utils.parsedate_tz(msg.get('date'))
> -    except:
> -        pass
> +    mdate = email.utils.parsedate_tz(msg.get('date'))
>      # In keeping with preserving the past, we have kept this next section(s).
>      # For all intents and purposes, this is not a proper way of maintaining
>      # a consistent ID in case of missing dates. It is recommended to use
>

Mime
View raw message