Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AE893200497 for ; Wed, 23 Aug 2017 22:13:01 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id ACDE716990C; Wed, 23 Aug 2017 20:13:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F3997169909 for ; Wed, 23 Aug 2017 22:13:00 +0200 (CEST) Received: (qmail 41741 invoked by uid 500); 23 Aug 2017 20:12:58 -0000 Mailing-List: contact commits-help@ponymail.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ponymail.incubator.apache.org Delivered-To: mailing list commits@ponymail.incubator.apache.org Received: (qmail 41732 invoked by uid 99); 23 Aug 2017 20:12:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Aug 2017 20:12:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A4CEAC01E5 for ; Wed, 23 Aug 2017 20:12:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.222 X-Spam-Level: X-Spam-Status: No, score=-4.222 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 3A2gfMQf8sxX for ; Wed, 23 Aug 2017 20:12:56 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 0E86D60E75 for ; Wed, 23 Aug 2017 20:12:54 +0000 (UTC) Received: (qmail 41224 invoked by uid 99); 23 Aug 2017 20:12:54 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Aug 2017 20:12:54 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 321B7F3292; Wed, 23 Aug 2017 20:12:54 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: sebb@apache.org To: commits@ponymail.incubator.apache.org Message-Id: <7e51a03809ac4300b896e0d6ec386099@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: incubator-ponymail git commit: Redundant close() calls Date: Wed, 23 Aug 2017 20:12:54 +0000 (UTC) archived-at: Wed, 23 Aug 2017 20:13:01 -0000 Repository: incubator-ponymail Updated Branches: refs/heads/master 5715502cf -> 54e690a06 Redundant close() calls Project: http://git-wip-us.apache.org/repos/asf/incubator-ponymail/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ponymail/commit/54e690a0 Tree: http://git-wip-us.apache.org/repos/asf/incubator-ponymail/tree/54e690a0 Diff: http://git-wip-us.apache.org/repos/asf/incubator-ponymail/diff/54e690a0 Branch: refs/heads/master Commit: 54e690a06a2db37779b828fab7209918c1c75552 Parents: 5715502 Author: Sebb Authored: Wed Aug 23 21:12:50 2017 +0100 Committer: Sebb Committed: Wed Aug 23 21:12:50 2017 +0100 ---------------------------------------------------------------------- tools/feedwrapper.py | 2 -- tools/install.py | 1 - tools/setup.py | 2 -- 3 files changed, 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-ponymail/blob/54e690a0/tools/feedwrapper.py ---------------------------------------------------------------------- diff --git a/tools/feedwrapper.py b/tools/feedwrapper.py index 18bc4ce..2c49f57 100755 --- a/tools/feedwrapper.py +++ b/tools/feedwrapper.py @@ -53,7 +53,6 @@ subscribe with open("%s/wrapper.log" % path, "a") as f: f.write("%s - %s: %s\n" % (msg.get('to'), msg.get('reply-to'), msg.get('subject'))) f.write("We've got a subscription request for %s. \n" % msg.get('reply-to')) - f.close() smtpObj = smtplib.SMTP('localhost') smtpObj.sendmail(sys.argv[1], [msg.get('reply-to')], """From: %s @@ -71,5 +70,4 @@ Subject: %s print(p.communicate(input=msg.as_string().encode('utf-8'))) p.stdin.close() f.write("-----\n") - f.close() \ No newline at end of file http://git-wip-us.apache.org/repos/asf/incubator-ponymail/blob/54e690a0/tools/install.py ---------------------------------------------------------------------- diff --git a/tools/install.py b/tools/install.py index a35a1df..fdd6953 100755 --- a/tools/install.py +++ b/tools/install.py @@ -65,7 +65,6 @@ if dname == 'ubuntu' or dname == 'debian': LuaCodeCache stat AcceptPathInfo On """) - f.close() if dname == 'ubuntu' and dver == '14.04': print("Ubuntu 14.04 specific step; Compiling mod_lua") http://git-wip-us.apache.org/repos/asf/incubator-ponymail/blob/54e690a0/tools/setup.py ---------------------------------------------------------------------- diff --git a/tools/setup.py b/tools/setup.py index d670c4e..bf646fb 100755 --- a/tools/setup.py +++ b/tools/setup.py @@ -504,7 +504,6 @@ generator: %s ############################################################### """ % (hostname, dbname, port, 'wait: active shard count' if ES_MAJOR == 5 else 'write: consistency level (default quorum)', genname)) - f.close() config_path = "../site/api/lib" config_file = "config.lua" @@ -544,7 +543,6 @@ local config = { } return config """ % (hostname, port, dbname, mlserver, mldom, "true" if wce else "false")) - f.close() print("Copying sample JS config to config.js (if needed)...") if not os.path.exists("../site/js/config.js") and os.path.exists("../site/js/config.js.sample"):