polygene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niclas Hedhman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (POLYGENE-286) If and else-if branches has the same condition
Date Sat, 09 Dec 2017 05:54:00 GMT

    [ https://issues.apache.org/jira/browse/POLYGENE-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284612#comment-16284612
] 

Niclas Hedhman commented on POLYGENE-286:
-----------------------------------------


Thanks. Did you run this on the entire 180,000 lines of code? And that is the only thing that
you found? Since I doubt that we are THAT good, perhaps there is more work needed on the tool...
:-)


> If and else-if branches has the same condition
> ----------------------------------------------
>
>                 Key: POLYGENE-286
>                 URL: https://issues.apache.org/jira/browse/POLYGENE-286
>             Project: Polygene
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: songwanging
>            Priority: Minor
>             Fix For: 3.1.0
>
>
> Our tool DeepTect has detected a piece of buggy code snippet, in which the if and else
branches has the same condition.
> Path: polygene-java/libraries/restlet/src/main/java/org/apache/polygene/library/restlet/serialization/PolygeneConverter.java
> {code:java}
>  protected <T> Representation create( Representation source, Class<T> objectClass
)
>     {
>         if( VARIANT_WWW_FORM_URLENCODED.isCompatible( source ) )
>         {
>             return objectFactory.newObject( FormRepresentation.class, source, objectClass
);
>         }
>         else if( VARIANT_WWW_FORM_URLENCODED.isCompatible( source ) )
>         {
>             //noinspection unchecked
>             return objectFactory.newObject( JsonRepresentation.class, source, objectClass
);
>         }
>         return null;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message