Mailing-List: contact dev-help@polygene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@polygene.apache.org
Message-ID: <5919DC17.5020104@apache.org>
Date: Mon, 15 May 2017 18:49:27 +0200
From: Paul Merlin <paulmerlin@apache.org>
User-Agent: Postbox 3.0.11 (Macintosh/20140602)
MIME-Version: 1.0
To: dev@polygene.apache.org
Subject: Re: Massive bug...
References: <CADmm+KeW3iJq5XFaT8Uh_yR9n8_3e=66LoiZE_Caxh8BHw1+Hw@mail.gmail.com>
In-Reply-To: <CADmm+KeW3iJq5XFaT8Uh_yR9n8_3e=66LoiZE_Caxh8BHw1+Hw@mail.gmail.com>
Content-Type: multipart/alternative;
 boundary="------------020403070006090802020507"
archived-at: Mon, 15 May 2017 16:49:34 -0000

--------------020403070006090802020507
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Nice find.

As I understand it, it's not a blocker.
It doesn't work as expected when you make a mistake.
We should fix this anyway!

But I wouldn't hold 3.0 and fix this afterwards.

Niclas, could you please fill issues to capture this?


Niclas Hedhman a écrit :
> Gang,
>
> By mistake I found a big bug...
>
>
> @Concerns( DefaultMethodsGenericSideEffect.class )
> public interface DefaultMethodsGenericSideEffects extends DefaultMethods
> {
>     @Override
>     default String sayHello( String name )
>     {
>         return greeting().get() + ", " + name + '!';
>     }
> }
>
> @AppliesTo( DefaultMethodsFilter.class )
> public static class DefaultMethodsGenericSideEffect extends
> SideEffectOf<InvocationHandler>
>     implements InvocationHandler
> {
>
>
>
> Do you see it?? Point is that there is no warning or anything, but the
> SideEffect is applied as a Concern, and the value returned from the
> SideEffect is the result of the method call.
>
> The description of the bug should be something like; "Concerns lacking
> @ConcernFor injection field is not rejected as a Concern" and the same
> thing is like for SideEffects, but I haven't tested that yet.
>
>
> Cheers

--------------020403070006090802020507--