polygene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niclas Hedhman (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (POLYGENE-231) Serialization 3.0
Date Tue, 14 Mar 2017 00:13:43 GMT

    [ https://issues.apache.org/jira/browse/POLYGENE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923256#comment-15923256
] 

Niclas Hedhman edited comment on POLYGENE-231 at 3/14/17 12:13 AM:
-------------------------------------------------------------------

I have had a look at the important bits and it looks reasonable.

What about ValueSerialization Type Lookup is wrong. (POLYGENE-105) ?

I think that in org.apache.polygene.serialization.javaxjson.JavaxJsonDeserializer around line
96-100
{code:java}
JavaxJsonAdapter<?> adapter = adapters.adapterFor( valueType );
if( adapter != null )
{
    return (T) adapter.deserialize( json, ( jsonValue, type ) -> doDeserialize( module,
type, jsonValue ) );
}
{code}
we need to determine if it is a "ValueComposite", and if so, then we need to dig up its Module,
and pass that module instead of the top level module that is done now, and after the deserialization,
set back to the old module.

And I am not sure if that is the only place or not.


was (Author: niclas):
I have had a look at the important bits and it looks reasonable.

What about ValueSerialization Type Lookup is wrong. (POLYGENE-105) ?

I think that in org.apache.polygene.serialization.javaxjson.JavaxJsonDeserializer around line
96-100
{code:java}
JavaxJsonAdapter<?> adapter = adapters.adapterFor( valueType );
if( adapter != null )
{
    return (T) adapter.deserialize( json, ( jsonValue, type ) -> doDeserialize( module,
type, jsonValue ) );
}
{code}
we need to determine if it is a "ValueComposite", and if so, then we need to dig up its Module,
and pass that module instead of the top level module that is done now, and after the deserialization,
set back to the old module.

> Serialization 3.0
> -----------------
>
>                 Key: POLYGENE-231
>                 URL: https://issues.apache.org/jira/browse/POLYGENE-231
>             Project: Polygene
>          Issue Type: Improvement
>            Reporter: Paul Merlin
>            Assignee: Paul Merlin
>             Fix For: 3.0
>
>
> Revamp the serialization SPI to fix outstanding issues, add missing features and remove
{{org.json}}.
> Implementation is in progress in the {{serialization-3.0}} branch.
> Github pull-request to browse the changes and comment: https://github.com/apache/polygene-java/pull/5



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message