Mailing-List: contact dev-help@zest.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zest.apache.org
Message-ID: <580A4B3A.1080700@nosphere.org>
Date: Fri, 21 Oct 2016 19:07:06 +0200
From: Paul Merlin <paul@nosphere.org>
User-Agent: Postbox 3.0.11 (Macintosh/20140602)
MIME-Version: 1.0
To: dev@zest.apache.org
Subject: Re: Design flaw in EntityStore SPI?
References: <CADmm+Keqyj7tK3k2UTxiBb+G3yZAed3vnVo+EnV9sFku9TcqrA@mail.gmail.com>
In-Reply-To: <CADmm+Keqyj7tK3k2UTxiBb+G3yZAed3vnVo+EnV9sFku9TcqrA@mail.gmail.com>
Content-Type: multipart/alternative;
 boundary="------------020000010901030902070409"
archived-at: Fri, 21 Oct 2016 17:07:18 -0000

--------------020000010901030902070409
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Makes sense to me

Niclas Hedhman a écrit :
> Hi again,
> While looking into the feasibility of implementing a Repository EntityStore
> I realized that the current SPI seems flawed.
>
> The TYPE of an entity is stored with the entity and not the entity type
> that is being processed by the outside world. And then type lookup is used
> via the current Module associated to the current UnitOfWork.
>
> It seems more logical to me that an EnttyDscriptor is passed down to the
> EntityStore, so that the type doesn't need to be looked up. For ES, this
> seems to work well, although this doesn't solve a similar issue in the
> Query system.
>
> I would like to change the EntityStoreSPI from
>
>
> public interface EntityStoreSPI
> {
>     EntityState newEntityState( EntityStoreUnitOfWork unitOfWork,
>                                 EntityReference identity,
>                                 EntityDescriptor entityDescriptor
>     );
>
>     EntityState entityStateOf( EntityStoreUnitOfWork unitOfWork,
>                                ModuleDescriptor module,
>                                EntityReference identity );
>
>     String versionOf( EntityStoreUnitOfWork unitOfWork,
>                       EntityReference identity );
>
>     StateCommitter applyChanges( EntityStoreUnitOfWork unitOfWork,
>                                  Iterable<EntityState> state );
> }
>
> to
>
> public interface EntityStoreSPI
> {
>     EntityState newEntityState( EntityStoreUnitOfWork unitOfWork,
>                                 EntityReference identity,
>                                 EntityDescriptor entityDescriptor
>     );
>
>     EntityState entityStateOf( EntityStoreUnitOfWork unitOfWork,
>                                EntityReference identity,
>                                EntityDescriptor entityDescriptor );
>
>     String versionOf( EntityStoreUnitOfWork unitOfWork,
>                       EntityReference identity,
>                       EntityDescriptor entityDescriptor );
>
>     StateCommitter applyChanges( EntityStoreUnitOfWork unitOfWork,
>                                  Iterable<EntityState> state );
> }
>
>
> which I think can handle the requirements of Repository ES more elegantly.
>
> WDYT?
>
> Cheers

--------------020000010901030902070409--