Return-Path: X-Original-To: apmail-zest-dev-archive@minotaur.apache.org Delivered-To: apmail-zest-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B2CED177BE for ; Mon, 27 Jul 2015 13:35:05 +0000 (UTC) Received: (qmail 89098 invoked by uid 500); 27 Jul 2015 13:35:05 -0000 Delivered-To: apmail-zest-dev-archive@zest.apache.org Received: (qmail 89021 invoked by uid 500); 27 Jul 2015 13:35:05 -0000 Mailing-List: contact dev-help@zest.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zest.apache.org Delivered-To: mailing list dev@zest.apache.org Received: (qmail 88957 invoked by uid 99); 27 Jul 2015 13:35:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jul 2015 13:35:05 +0000 Date: Mon, 27 Jul 2015 13:35:05 +0000 (UTC) From: "Paul Merlin (JIRA)" To: dev@zest.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (ZEST-107) Entity SPI: JSONEntityState cloning logic is flawed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Paul Merlin created ZEST-107: -------------------------------- Summary: Entity SPI: JSONEntityState cloning logic is flawed Key: ZEST-107 URL: https://issues.apache.org/jira/browse/ZEST-107 Project: Zest Issue Type: Bug Affects Versions: 2.0 Reporter: Tibor Mlynarik Assignee: Paul Merlin Fix For: 2.1 The cloneStateIfGlobalStateLoaded() method of JSONEntityState is called before any change is made to the entity state. This method starts with the following check: if( isStateNotCloned() ) { return; } // Do the clone And the (private) isStateNotCloned() method returns: status == EntityStatus.LOADED IOW, the code says that it will clone state if status is loaded, but it does the opposite! See discussion: http://s.apache.org/1QI -- This message was sent by Atlassian JIRA (v6.3.4#6332)