Mailing-List: contact dev-help@zest.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zest.apache.org
MIME-Version: 1.0
Sender: hedhman@gmail.com
In-Reply-To: 
 <CADmm+Ke3pmE1FY8wJaZ6cJJ6py7yAkM1FB7exoVRaXX+_xXF1g@mail.gmail.com>
References: 
 <CADmm+Ke2ZxxwnmuHK9L-HRoirdNevmKbxj=Zv+N13DCfMm-ELw@mail.gmail.com>
 <CADmm+KcE6isx-bP1DZDK5hAp+ixtffhKDB4UZLzzjF3wwMgnFQ@mail.gmail.com>
 <CADmm+KeYtUVxTvZ465yyZ0gi+zubS32rvDovPDce74OGBV3GiQ@mail.gmail.com>
 <559FCC8D.5020807@nosphere.org>
 <CADmm+KcMbjmfgvLcH=w4MsSBGAc4+eZWx4+2U8z8P2a6D2ot3Q@mail.gmail.com>
 <CADmm+Kf6dopP8iFOB=okMgRfHEe_UQVudSa4o10cRaxLRrNDcw@mail.gmail.com>
 <CADmm+KdL6B2Ff_f1bnw6sMJLjdDiLjhg2wdA6TVk4PzCWZ+YXA@mail.gmail.com>
 <CADmm+Ke3pmE1FY8wJaZ6cJJ6py7yAkM1FB7exoVRaXX+_xXF1g@mail.gmail.com>
From: Niclas Hedhman <niclas@hedhman.org>
Date: Fri, 10 Jul 2015 17:16:18 +0300
Message-ID: 
 <CADmm+Kd1xAgTmoUyr5Hp6O7HS_ZkyZ_e12R0+XgNBB36wvitpQ@mail.gmail.com>
Subject: Re: Test Error found...
To: dev <dev@zest.apache.org>
Content-Type: multipart/alternative; boundary=001a1134bad022e81b051a860512

--001a1134bad022e81b051a860512
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

That was quick... single() also throw IllegalArgumentException on zero
results. I added a atMostOne() method in Iterables. All this will be
re-written in 3.0 and use Java 8 Function+Stream API.

On Fri, Jul 10, 2015 at 5:09 PM, Niclas Hedhman <niclas@hedhman.org> wrote:

> I am introducing a small fix (use single() instead of first(), catch
> IllegalArgumentException and rethrow a AmbiguousTypeException), and the
> output is
>
> org.qi4j.api.composite.AmbiguousTypeException: More than one model matche=
s
> the classname
> org.qi4j.api.value.ValueSerialization:[OrgJsonValueSerializationService(a=
ctive=3Dfalse,module=3D'Module
> 1'), JacksonValueSerializationService(active=3Dfalse,module=3D'Module 1')=
]
>
>
> for the case that I just detected.
>
> I am starting a local build to see what else fails and whether there is
> concern for this change. Perhaps some way it is needed to ignore ambiguou=
s
> types in some usecase.
>
>
> I'll report back later.
> Niclas
>
> On Fri, Jul 10, 2015 at 4:56 PM, Niclas Hedhman <niclas@hedhman.org>
> wrote:
>
>> So, the question is; SHOULD a AmbiguousTypeException be thrown when one
>> is asking for a @Service injection of a composite type or
>> ServiceReference<T>?
>>
>> And I am pretty sure the exact same code is called if one calls
>> ServiceFinder.findService(), and that would also throw the
>> AmbiguousTypeException.
>>
>>
>> Cheers
>> Niclas
>>
>> On Fri, Jul 10, 2015 at 4:53 PM, Niclas Hedhman <niclas@hedhman.org>
>> wrote:
>>
>>> And it is not done there... It takes, and instantiates, the first one.
>>> Line 378 in TypeLookup
>>>
>>> On Fri, Jul 10, 2015 at 4:50 PM, Niclas Hedhman <niclas@hedhman.org>
>>> wrote:
>>>
>>>> The findService() (single instance) should be checking ambiguity, wher=
e
>>>> as findServices() shouldn't. I am looking into that at the moment.
>>>>
>>>> On Fri, Jul 10, 2015 at 4:45 PM, Paul Merlin <paul@nosphere.org> wrote=
:
>>>>
>>>>> Good catch Niclas.
>>>>>
>>>>> No AmbiguousTypeException should be expected though.
>>>>>
>>>>> There is two services registered for the ValueSerialization type with
>>>>> !=3D
>>>>> identities, possibly different qualifiers etc... there's no type
>>>>> ambiguity with multiple services of the same type.
>>>>>
>>>>> Think @Service Iterable<ValueSerialization> inject;
>>>>>
>>>>> /Paul
>>>>>
>>>>> Niclas Hedhman a =C3=A9crit :
>>>>> > EntityTestAssembler is the answer... which is invoked in the
>>>>> > AbstractValueCompositeSerializationTest.
>>>>> >
>>>>> > I'll resolve that. Sorry for the noise.
>>>>> >
>>>>> > On Fri, Jul 10, 2015 at 4:31 PM, Niclas Hedhman <niclas@hedhman.org=
>
>>>>> wrote:
>>>>> >
>>>>> >> So, the Module contains TWO ValueSerialization systems, both the
>>>>> OrgJson
>>>>> >> and the Jackson ones.
>>>>> >>
>>>>> >> That should then raise the question, Why don't we get
>>>>> >> AmbigiousTypeException??
>>>>> >>
>>>>> >> There are also a MemoryEntityStore and a UuidIdentityGenerator in
>>>>> the
>>>>> >> Module.... Where are those coming from?
>>>>> >>
>>>>> >>
>>>>> >> Cheers
>>>>> >>
>>>>> >> On Fri, Jul 10, 2015 at 4:25 PM, Niclas Hedhman <niclas@hedhman.or=
g
>>>>> >
>>>>> >> wrote:
>>>>> >>
>>>>> >>> I think I have found a Testcase problem, while trying to improve
>>>>> the
>>>>> >>> ValueSerialization subsystem.
>>>>> >>>
>>>>> >>> To show what I mean;
>>>>> >>>
>>>>> >>>    a. Put a breakpoint on the first line in the only(!) test in
>>>>> >>> AbstractValueCompositeSerializationTest
>>>>> >>>
>>>>> >>>    b. Run the JacksonValueCompositeSerializationTest.
>>>>> >>>
>>>>> >>>    c. At breakpoint, look at the this.valueSerialization member.
>>>>> It has
>>>>> >>> a ServiceComposite reference to the
>>>>> OrgJsonValueSerializationService,
>>>>> >>> not the Jackson one.
>>>>> >>>
>>>>> >>>
>>>>> >>> I am trying to figure out how this is at all possible.
>>>>> >>>
>>>>> >>>
>>>>> >>> Cheers
>>>>> >>> --
>>>>> >>> Niclas Hedhman, Software Developer
>>>>> >>> http://zest.apache.org - New Energy for Java
>>>>> >>>
>>>>> >> --
>>>>> >> Niclas Hedhman, Software Developer
>>>>> >> http://zest.apache.org - New Energy for Java
>>>>> >>
>>>>> >
>>>>> >
>>>>> >
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Niclas Hedhman, Software Developer
>>>> http://zest.apache.org - New Energy for Java
>>>>
>>>
>>>
>>>
>>> --
>>> Niclas Hedhman, Software Developer
>>> http://zest.apache.org - New Energy for Java
>>>
>>
>>
>>
>> --
>> Niclas Hedhman, Software Developer
>> http://zest.apache.org - New Energy for Java
>>
>
>
>
> --
> Niclas Hedhman, Software Developer
> http://zest.apache.org - New Energy for Java
>


--=20
Niclas Hedhman, Software Developer
http://zest.apache.org - New Energy for Java

--001a1134bad022e81b051a860512--